From: Rob Herring <robh@kernel.org>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
Ansuel Smith <ansuelsmth@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/2] devicetree: bindings: phy: Document ipq806x dwc3 qcom phy
Date: Fri, 1 May 2020 16:10:46 -0500 [thread overview]
Message-ID: <20200501211046.GA31395@bogus> (raw)
In-Reply-To: <20200429211926.4952-2-ansuelsmth@gmail.com>
On Wed, 29 Apr 2020 23:19:25 +0200, Ansuel Smith wrote:
> Document dwc3 qcom phy hs and ss phy bindings needed to correctly
> inizialize and use usb on ipq806x SoC.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> v4:
> * Add qcom to specific bindings
> v3:
> * Use explicit reg instead of regmap
>
> .../bindings/phy/qcom,ipq806x-usb-phy-hs.yaml | 58 +++++++++++++++
> .../bindings/phy/qcom,ipq806x-usb-phy-ss.yaml | 73 +++++++++++++++++++
> 2 files changed, 131 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-hs.yaml
> create mode 100644 Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml: properties:qcom,tx_deamp_3_5db: {'maxItems': 1, 'description': 'Override value for transmit preemphasis.', 'default': 23} is not valid under any of the given schemas (Possible causes of the failure):
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml: properties:qcom,tx_deamp_3_5db: 'not' is a required property
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml: properties:qcom,rx_eq: {'maxItems': 1, 'description': 'Override value for rx_eq.', 'default': 4} is not valid under any of the given schemas (Possible causes of the failure):
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml: properties:qcom,rx_eq: 'not' is a required property
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml: properties:qcom,mpll: {'maxItems': 1, 'description': 'Override value for mpll.', 'default': 0} is not valid under any of the given schemas (Possible causes of the failure):
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml: properties:qcom,mpll: 'not' is a required property
Documentation/devicetree/bindings/Makefile:11: recipe for target 'Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.example.dts' failed
make[1]: *** [Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
warning: no schema found in file: Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml: ignoring, error in schema: properties: qcom,mpll
warning: no schema found in file: Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,ipq806x-usb-phy-ss.yaml: ignoring, error in schema: properties: qcom,mpll
Makefile:1300: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1279692
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
prev parent reply other threads:[~2020-05-01 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 21:19 [PATCH v4 1/2] phy: qualcomm: add qcom ipq806x dwc usb phy driver Ansuel Smith
2020-04-29 21:19 ` [PATCH v4 2/2] devicetree: bindings: phy: Document ipq806x dwc3 qcom phy Ansuel Smith
2020-05-01 21:10 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501211046.GA31395@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).