linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: net: add IPA iommus property
@ 2020-05-01 21:45 Alex Elder
  2020-05-04 18:23 ` Alex Elder
  0 siblings, 1 reply; 2+ messages in thread
From: Alex Elder @ 2020-05-01 21:45 UTC (permalink / raw)
  To: robh+dt, bjorn.andersson, agross
  Cc: evgreen, subashab, cpratapa, davem, devicetree, netdev,
	linux-arm-msm, linux-kernel

The IPA accesses "IMEM" and main system memory through an SMMU, so
its DT node requires an iommus property to define range of stream IDs
it uses.

Signed-off-by: Alex Elder <elder@linaro.org>
---
 Documentation/devicetree/bindings/net/qcom,ipa.yaml | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
index 140f15245654..7b749fc04c32 100644
--- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
@@ -20,7 +20,10 @@ description:
   The GSI is an integral part of the IPA, but it is logically isolated
   and has a distinct interrupt and a separately-defined address space.
 
-  See also soc/qcom/qcom,smp2p.txt and interconnect/interconnect.txt.
+  See also soc/qcom/qcom,smp2p.txt and interconnect/interconnect.txt.  See
+  iommu/iommu.txt and iommu/arm,smmu.yaml for more information about SMMU
+  bindings.
+
 
   - |
     --------             ---------
@@ -54,6 +57,9 @@ properties:
       - const: ipa-shared
       - const: gsi
 
+  iommus:
+    maxItems: 1
+
   clocks:
     maxItems: 1
 
@@ -126,6 +132,7 @@ properties:
 
 required:
   - compatible
+  - iommus
   - reg
   - clocks
   - interrupts
@@ -164,6 +171,7 @@ examples:
                 modem-init;
                 modem-remoteproc = <&mss_pil>;
 
+                iommus = <&apps_smmu 0x720 0x3>;
                 reg = <0 0x1e40000 0 0x7000>,
                         <0 0x1e47000 0 0x2000>,
                         <0 0x1e04000 0 0x2c000>;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: net: add IPA iommus property
  2020-05-01 21:45 [PATCH] dt-bindings: net: add IPA iommus property Alex Elder
@ 2020-05-04 18:23 ` Alex Elder
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Elder @ 2020-05-04 18:23 UTC (permalink / raw)
  To: robh+dt, bjorn.andersson, agross
  Cc: evgreen, subashab, cpratapa, davem, devicetree, netdev,
	linux-arm-msm, linux-kernel

On 5/1/20 4:45 PM, Alex Elder wrote:
> The IPA accesses "IMEM" and main system memory through an SMMU, so
> its DT node requires an iommus property to define range of stream IDs
> it uses.
> 
> Signed-off-by: Alex Elder <elder@linaro.org>

Please ignore this patch.  I have reposted it as the first
patch in a new series:
   https://lore.kernel.org/netdev/20200504175859.22606-1-elder@linaro.org/

					-Alex

> ---
>   Documentation/devicetree/bindings/net/qcom,ipa.yaml | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index 140f15245654..7b749fc04c32 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -20,7 +20,10 @@ description:
>     The GSI is an integral part of the IPA, but it is logically isolated
>     and has a distinct interrupt and a separately-defined address space.
>   
> -  See also soc/qcom/qcom,smp2p.txt and interconnect/interconnect.txt.
> +  See also soc/qcom/qcom,smp2p.txt and interconnect/interconnect.txt.  See
> +  iommu/iommu.txt and iommu/arm,smmu.yaml for more information about SMMU
> +  bindings.
> +
>   
>     - |
>       --------             ---------
> @@ -54,6 +57,9 @@ properties:
>         - const: ipa-shared
>         - const: gsi
>   
> +  iommus:
> +    maxItems: 1
> +
>     clocks:
>       maxItems: 1
>   
> @@ -126,6 +132,7 @@ properties:
>   
>   required:
>     - compatible
> +  - iommus
>     - reg
>     - clocks
>     - interrupts
> @@ -164,6 +171,7 @@ examples:
>                   modem-init;
>                   modem-remoteproc = <&mss_pil>;
>   
> +                iommus = <&apps_smmu 0x720 0x3>;
>                   reg = <0 0x1e40000 0 0x7000>,
>                           <0 0x1e47000 0 0x2000>,
>                           <0 0x1e04000 0 0x2c000>;
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-04 18:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-01 21:45 [PATCH] dt-bindings: net: add IPA iommus property Alex Elder
2020-05-04 18:23 ` Alex Elder

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).