From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0119C47257 for ; Mon, 4 May 2020 18:03:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C305620707 for ; Mon, 4 May 2020 18:03:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588615399; bh=EWFFcTEu2u5Wpuly/p+eP+0dSJ8gj+K2GbeLtohLHyI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Qo+D5hT/a8M8JzmhUDY39n5nvd78vPNoEI0OXlWXa7oQnOTroYDFtyYUsXhDJeb50 valp+gHYgHRUnhvSJrr0JPLExYt8e2i8t+upRDtn8B56I0TSzNR8GSPBv+yhwomPL4 jVepdo9WgNxfcw1nGkxlrDpeOunBNgR+Zz2jY0zA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731488AbgEDSDS (ORCPT ); Mon, 4 May 2020 14:03:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:60310 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731481AbgEDSDQ (ORCPT ); Mon, 4 May 2020 14:03:16 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E5D752073E; Mon, 4 May 2020 18:03:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588615396; bh=EWFFcTEu2u5Wpuly/p+eP+0dSJ8gj+K2GbeLtohLHyI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KYiRpTOJnVINKODHA3SY3qLJOKrb+dvQ6ykC52Ddq59CU2C615x254Cdn90XSZRvx 3VTVBq2WA1spBGZm3UAExxyfny3PtipUKBKy9sXZ/nSWnWpFtth5mu2frg3atlNUc7 s0RuLywfUCnEAdEozHoRW6rVMMQ8nbkOr0JOtKu0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wu Bo , Takashi Iwai Subject: [PATCH 5.4 21/57] ALSA: hda/hdmi: fix without unlocked before return Date: Mon, 4 May 2020 19:57:25 +0200 Message-Id: <20200504165458.197655876@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504165456.783676004@linuxfoundation.org> References: <20200504165456.783676004@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wu Bo commit a2f647240998aa49632fb09b01388fdf2b87acfc upstream. Fix the following coccicheck warning: sound/pci/hda/patch_hdmi.c:1852:2-8: preceding lock on line 1846 After add sanity check to pass klockwork check, The spdif_mutex should be unlock before return true in check_non_pcm_per_cvt(). Fixes: 960a581e22d9 ("ALSA: hda: fix some klockwork scan warnings") Signed-off-by: Wu Bo Cc: Link: https://lore.kernel.org/r/1587907042-694161-1-git-send-email-wubo40@huawei.com Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_hdmi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -1861,8 +1861,10 @@ static bool check_non_pcm_per_cvt(struct /* Add sanity check to pass klockwork check. * This should never happen. */ - if (WARN_ON(spdif == NULL)) + if (WARN_ON(spdif == NULL)) { + mutex_unlock(&codec->spdif_mutex); return true; + } non_pcm = !!(spdif->status & IEC958_AES0_NONAUDIO); mutex_unlock(&codec->spdif_mutex); return non_pcm;