From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 3/3] clk: at91: allow setting all PMC clock parents via DT
Date: Mon, 4 May 2020 22:12:21 +0200 [thread overview]
Message-ID: <20200504201220.GA21544@qmqm.qmqm.pl> (raw)
In-Reply-To: <20200504200431.GI34497@piout.net>
On Mon, May 04, 2020 at 10:04:31PM +0200, Alexandre Belloni wrote:
> Hi,
>
> On 03/05/2020 19:19:26+0200, Michał Mirosław wrote:
> > diff --git a/include/dt-bindings/clock/at91.h b/include/dt-bindings/clock/at91.h
> > index c3f4aa6a2d29..adcf608b41fa 100644
> > --- a/include/dt-bindings/clock/at91.h
> > +++ b/include/dt-bindings/clock/at91.h
> > @@ -21,6 +21,9 @@
> > #define PMC_MCK2 4
> > #define PMC_I2S0_MUX 5
> > #define PMC_I2S1_MUX 6
> > +#define PMC_PLLACK 7
> > +#define PMC_PLLBCK 8
> > +#define PMC_AUDIOPLLCK 8 /* SAMA5D2-only, no PLLB there */
> Just use 9 here because we can't know for sure that a future SoC won't
> have both a PLLB and audio PLL.
Ok. I assumed that PLLB is only in old generations. Fix coming shortly.
Best Regrads,
Michał Mirosław
prev parent reply other threads:[~2020-05-04 20:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 17:19 [PATCH v4 0/3] clk: at91: support configuring more clocks via DT Michał Mirosław
2020-05-03 17:19 ` [PATCH v4 2/3] clk: at91: allow setting PCKx parent " Michał Mirosław
2020-05-04 20:01 ` Alexandre Belloni
2020-05-03 17:19 ` [PATCH v4 1/3] clk: at91: optimize pmc data allocation Michał Mirosław
2020-05-03 17:19 ` [PATCH v4 3/3] clk: at91: allow setting all PMC clock parents via DT Michał Mirosław
2020-05-04 20:04 ` Alexandre Belloni
2020-05-04 20:12 ` Michał Mirosław [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504201220.GA21544@qmqm.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).