From: SeongJae Park <sjpark@amazon.com>
To: <davem@davemloft.net>
Cc: <viro@zeniv.linux.org.uk>, <kuba@kernel.org>,
<gregkh@linuxfoundation.org>, <edumazet@google.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
SeongJae Park <sjpark@amazon.de>
Subject: [PATCH net 0/2] Revert the 'socket_alloc' life cycle change
Date: Tue, 5 May 2020 09:28:39 +0200 [thread overview]
Message-ID: <20200505072841.25365-1-sjpark@amazon.com> (raw)
From: SeongJae Park <sjpark@amazon.de>
The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the
deallocation of 'socket_alloc' to be done asynchronously using RCU, as
same to 'sock.wq'. And the following commit 333f7909a857 ("coallocate
socket_sq with socket itself") made those to have same life cycle.
The changes made the code much more simple, but also made 'socket_alloc'
live longer than before. For the reason, user programs intensively
repeating allocations and deallocations of sockets could cause memory
pressure on recent kernels.
To avoid the problem, this commit reverts the changes.
SeongJae Park (2):
Revert "coallocate socket_wq with socket itself"
Revert "sockfs: switch to ->free_inode()"
drivers/net/tap.c | 5 +++--
drivers/net/tun.c | 8 +++++---
include/linux/if_tap.h | 1 +
include/linux/net.h | 4 ++--
include/net/sock.h | 4 ++--
net/core/sock.c | 2 +-
net/socket.c | 23 ++++++++++++++++-------
7 files changed, 30 insertions(+), 17 deletions(-)
--
2.17.1
next reply other threads:[~2020-05-05 7:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 7:28 SeongJae Park [this message]
2020-05-05 7:28 ` [PATCH net 1/2] Revert "coallocate socket_wq with socket itself" SeongJae Park
2020-05-05 7:45 ` Greg KH
2020-05-05 8:04 ` SeongJae Park
2020-05-05 7:28 ` [PATCH net 2/2] Revert "sockfs: switch to ->free_inode()" SeongJae Park
2020-05-05 7:45 ` Greg KH
2020-05-05 8:09 ` SeongJae Park
2020-05-05 12:44 ` [PATCH net 0/2] Revert the 'socket_alloc' life cycle change Al Viro
2020-05-05 14:24 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505072841.25365-1-sjpark@amazon.com \
--to=sjpark@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sjpark@amazon.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).