From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Cc: Stephane Eranian <eranian@google.com>, Ian Rogers <irogers@google.com>
Subject: [PATCH v3 0/3] Improvements for kallsyms__parse
Date: Tue, 5 May 2020 07:36:22 -0700 [thread overview]
Message-ID: <20200505143625.147832-1-irogers@google.com> (raw)
kallsyms__parse is called 4 times during perf record startup. Add a
benchmark to measure its performance. Transition it to using the api
io.h buffered reading, improving performance by ~8% or saving ~5% from
perf record start up time.
v3. Fixed a link error report in hex2u64 by jolsa@redhat.com.
v2. Fix the err return value for success, error reported by
jolsa@redhat.com. Add clean-up for hex2u64.
Ian Rogers (3):
perf bench: add kallsyms parsing
lib kallsyms: parse using io api
lib kallsyms: move hex2u64 out of header
tools/lib/api/io.h | 3 ++
tools/lib/symbol/kallsyms.c | 86 ++++++++++++++-----------------
tools/lib/symbol/kallsyms.h | 2 -
tools/perf/bench/Build | 1 +
tools/perf/bench/bench.h | 1 +
tools/perf/bench/kallsyms-parse.c | 75 +++++++++++++++++++++++++++
tools/perf/builtin-bench.c | 1 +
tools/perf/util/symbol.c | 14 +++++
8 files changed, 133 insertions(+), 50 deletions(-)
create mode 100644 tools/perf/bench/kallsyms-parse.c
--
2.26.2.526.g744177e7f7-goog
next reply other threads:[~2020-05-05 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 14:36 Ian Rogers [this message]
2020-05-05 14:36 ` [PATCH v3 1/3] perf bench: add kallsyms parsing Ian Rogers
2020-05-05 14:36 ` [PATCH v3 2/3] lib kallsyms: parse using io api Ian Rogers
2020-05-05 14:36 ` [PATCH v3 3/3] lib kallsyms: move hex2u64 out of header Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505143625.147832-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).