From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 079C3C47254 for ; Tue, 5 May 2020 18:07:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7099206FA for ; Tue, 5 May 2020 18:07:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730712AbgEESHj (ORCPT ); Tue, 5 May 2020 14:07:39 -0400 Received: from muru.com ([72.249.23.125]:52916 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729315AbgEESHj (ORCPT ); Tue, 5 May 2020 14:07:39 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id C3AD880A5; Tue, 5 May 2020 18:08:26 +0000 (UTC) Date: Tue, 5 May 2020 11:07:34 -0700 From: Tony Lindgren To: Lokesh Vutla Cc: daniel.lezcano@linaro.org, Tero Kristo , Sekhar Nori , Suman Anna , Linux OMAP Mailing List , linux-kernel@vger.kernel.org Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: Do one override clock parent in prepare() Message-ID: <20200505180734.GN37466@atomide.com> References: <20200427172831.16546-1-lokeshvutla@ti.com> <20200428182209.GT37466@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200428182209.GT37466@atomide.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Tony Lindgren [200428 18:23]: > * Lokesh Vutla [200427 17:29]: > > omap_dm_timer_prepare() is setting up the parent 32KHz clock. This > > prepare() gets called by request_timer in the client's driver. Because of > > this, the timer clock parent that is set with assigned-clock-parent is being > > overwritten. So drop this default setting of parent in prepare(). > > > > Signed-off-by: Lokesh Vutla > > This works just fine for me but depends on the dts changes. > > Daniel, for merging, do you want to set up an immutable branch > for the related dts change and this? I'm afraid it will conflict > with the related systimer changes for the dts otherwise. So I've pushed out an immutable branch for the dts changes this patch depends on against v5.7-rc1 as omap-for-v5.8/dt-timer [0][1]. Daniel feel free to merge it in to apply this clocksource patch if no more comments: Acked-by: Tony Lindgren [0] git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git omap-for-v5.8/dt-timer [1] https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git/log/?h=omap-for-v5.8/dt-timer