From: Borislav Petkov <bp@suse.de>
To: akpm@linux-foundation.org
Cc: mm-commits@vger.kernel.org, ndesaulniers@google.com,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: + arch-x86-makefile-use-config_shell.patch added to -mm tree
Date: Tue, 5 May 2020 23:19:32 +0200 [thread overview]
Message-ID: <20200505211932.GE6880@zn.tnic> (raw)
In-Reply-To: <20200505211301.9_zLPwR3D%akpm@linux-foundation.org>
On Tue, May 05, 2020 at 02:13:01PM -0700, akpm@linux-foundation.org wrote:
>
> The patch titled
> Subject: arch/x86/Makefile: use $(CONFIG_SHELL)
> has been added to the -mm tree. Its filename is
> arch-x86-makefile-use-config_shell.patch
>
> This patch should soon appear at
> http://ozlabs.org/~akpm/mmots/broken-out/arch-x86-makefile-use-config_shell.patch
> and later at
> http://ozlabs.org/~akpm/mmotm/broken-out/arch-x86-makefile-use-config_shell.patch
>
> Before you just go and hit "reply", please:
> a) Consider who else should be cc'ed
> b) Prefer to cc a suitable mailing list as well
> c) Ideally: find the original patch on the mailing list and do a
> reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
>
> The -mm tree is included into linux-next and is updated
> there every 3-4 working days
>
> ------------------------------------------------------
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: arch/x86/Makefile: use $(CONFIG_SHELL)
>
> When scripts/x86-check-compiler.sh doesn't have the x bit set:
>
> q:/usr/src/25> make clean
> make: execvp: ./scripts/x86-check-compiler.sh: Permission denied
>
> Fix this by using $(CONFIG_SHELL).
>
> This will happen if the user downloads and applies patch-5.7.tar.gz, since
> patch(1) doesn't preserve the x bit.
>
> Fixes: 73da86741e7f7 ("x86/build: Check whether the compiler is sane")
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> arch/x86/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/x86/Makefile~arch-x86-makefile-use-config_shell
> +++ a/arch/x86/Makefile
> @@ -2,7 +2,7 @@
> # Unified Makefile for i386 and x86_64
>
> # Check the compiler
> -sane_compiler := $(shell $(srctree)/scripts/x86-check-compiler.sh $(CC))
> +sane_compiler := $($(CONFIG_SHELL) $(srctree)/scripts/x86-check-compiler.sh $(CC))
> $(if $(sane_compiler),$(error $(CC) check failed. Aborting),)
>
> # select defconfig based on actual architecture
> _
Ah, interesting.
Thanks Andrew, I'll queue it tomorrow through tip.
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
next parent reply other threads:[~2020-05-05 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200505211301.9_zLPwR3D%akpm@linux-foundation.org>
2020-05-05 21:19 ` Borislav Petkov [this message]
2020-05-06 7:56 ` [tip: x86/build] x86/build: Use $(CONFIG_SHELL) tip-bot2 for Andrew Morton
2020-05-17 13:08 ` tip-bot2 for Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505211932.GE6880@zn.tnic \
--to=bp@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).