linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: manivannan.sadhasivam@linaro.org
Cc: kvalo@codeaurora.org, bjorn.andersson@linaro.org,
	hemantk@codeaurora.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, clew@codeaurora.org,
	gregkh@linuxfoundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] net: qrtr: Add MHI transport layer
Date: Wed, 06 May 2020 13:49:40 -0700 (PDT)	[thread overview]
Message-ID: <20200506.134940.1001463900310607910.davem@davemloft.net> (raw)
In-Reply-To: <20200506045015.13421-1-manivannan.sadhasivam@linaro.org>

From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Date: Wed,  6 May 2020 10:20:14 +0530

> +/* From QRTR to MHI */
> +static void qcom_mhi_qrtr_ul_callback(struct mhi_device *mhi_dev,
> +				      struct mhi_result *mhi_res)
> +{
> +	struct sk_buff *skb = (struct sk_buff *)mhi_res->buf_addr;

You never need to cast to another pointer type from "void *", that's
the whole point of a void pointer.

So please remove this "struct sk_buff *" cast, thank you.

Please audit your entire submission for this problem.

  parent reply	other threads:[~2020-05-06 20:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06  4:50 [PATCH 1/2] net: qrtr: Add MHI transport layer Manivannan Sadhasivam
2020-05-06  4:50 ` [PATCH 2/2] net: qrtr: Do not depend on ARCH_QCOM Manivannan Sadhasivam
2020-05-06 20:49 ` David Miller [this message]
2020-05-06 20:50 ` [PATCH 1/2] net: qrtr: Add MHI transport layer David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200506.134940.1001463900310607910.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bjorn.andersson@linaro.org \
    --cc=clew@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hemantk@codeaurora.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).