From: Christoph Hellwig <hch@lst.de>
To: Martijn Coenen <maco@android.com>
Cc: axboe@kernel.dk, hch@lst.de, ming.lei@redhat.com,
narayan@google.com, zezeozue@google.com, kernel-team@android.com,
maco@google.com, bvanassche@acm.org, Chaitanya.Kulkarni@wdc.com,
jaegeuk@kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 08/10] loop: Rework lo_ioctl() __user argument casting
Date: Wed, 6 May 2020 08:07:41 +0200 [thread overview]
Message-ID: <20200506060741.GE10771@lst.de> (raw)
In-Reply-To: <20200429140341.13294-9-maco@android.com>
On Wed, Apr 29, 2020 at 04:03:39PM +0200, Martijn Coenen wrote:
> In preparation for a new ioctl that needs to copy_from_user(); makes the
> code easier to read as well.
>
> Signed-off-by: Martijn Coenen <maco@android.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
Btw, it seems like you have dropped all the reviews from the previous
versions, even if nothing substantial changed. Please keep them unless
a patch actually is reworked.
next prev parent reply other threads:[~2020-05-06 6:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 14:03 [PATCH v4 00/10] Add a new LOOP_CONFIGURE ioctl Martijn Coenen
2020-04-29 14:03 ` [PATCH v4 01/10] loop: Factor out loop size validation Martijn Coenen
2020-04-29 14:12 ` Ming Lei
2020-05-01 11:33 ` Martijn Coenen
2020-05-01 17:26 ` Christoph Hellwig
2020-04-29 14:03 ` [PATCH v4 02/10] loop: Factor out setting loop device size Martijn Coenen
2020-05-01 17:26 ` Christoph Hellwig
2020-04-29 14:03 ` [PATCH v4 03/10] loop: Switch to set_capacity_revalidate_and_notify() Martijn Coenen
2020-05-01 17:27 ` Christoph Hellwig
2020-04-29 14:03 ` [PATCH v4 04/10] loop: Refactor loop_set_status() size calculation Martijn Coenen
2020-05-01 17:30 ` Christoph Hellwig
2020-05-01 19:33 ` Martijn Coenen
2020-05-06 5:10 ` Christoph Hellwig
2020-05-06 6:03 ` Christoph Hellwig
2020-04-29 14:03 ` [PATCH v4 05/10] loop: Remove figure_loop_size() Martijn Coenen
2020-05-06 6:04 ` Christoph Hellwig
2020-04-29 14:03 ` [PATCH v4 06/10] loop: Factor out configuring loop from status Martijn Coenen
2020-05-06 6:05 ` Christoph Hellwig
2020-04-29 14:03 ` [PATCH v4 07/10] loop: Move loop_set_status_from_info() and friends up Martijn Coenen
2020-05-06 6:06 ` Christoph Hellwig
2020-04-29 14:03 ` [PATCH v4 08/10] loop: Rework lo_ioctl() __user argument casting Martijn Coenen
2020-05-06 6:07 ` Christoph Hellwig [this message]
2020-04-29 14:03 ` [PATCH v4 09/10] loop: Clean up LOOP_SET_STATUS lo_flags handling Martijn Coenen
2020-05-06 6:08 ` Christoph Hellwig
2020-04-29 14:03 ` [PATCH v4 10/10] loop: Add LOOP_CONFIGURE ioctl Martijn Coenen
2020-05-06 6:09 ` Christoph Hellwig
2020-05-06 9:55 ` Martijn Coenen
2020-05-06 9:44 ` Michael Kerrisk (man-pages)
2020-05-06 9:57 ` Martijn Coenen
2020-05-12 6:46 ` Martijn Coenen
2020-05-13 2:29 ` Jens Axboe
2020-05-13 2:30 ` Jens Axboe
2020-05-13 7:07 ` Martijn Coenen
2020-05-13 10:22 ` Christoph Hellwig
2020-05-13 13:49 ` Martijn Coenen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506060741.GE10771@lst.de \
--to=hch@lst.de \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=maco@google.com \
--cc=ming.lei@redhat.com \
--cc=narayan@google.com \
--cc=zezeozue@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).