linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net: bridge: return false in br_mrp_enabled()
@ 2020-05-06  6:16 Jason Yan
  2020-05-06  9:47 ` Nikolay Aleksandrov
  2020-05-06 20:57 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Jason Yan @ 2020-05-06  6:16 UTC (permalink / raw)
  To: roopa, nikolay, davem, kuba, bridge, netdev, linux-kernel; +Cc: Jason Yan

Fix the following coccicheck warning:

net/bridge/br_private.h:1334:8-9: WARNING: return of 0/1 in function
'br_mrp_enabled' with return type bool

Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 net/bridge/br_private.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index c35647cb138a..78d3a951180d 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -1331,7 +1331,7 @@ static inline int br_mrp_process(struct net_bridge_port *p, struct sk_buff *skb)
 
 static inline bool br_mrp_enabled(struct net_bridge *br)
 {
-	return 0;
+	return false;
 }
 
 static inline void br_mrp_port_del(struct net_bridge *br,
-- 
2.21.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: bridge: return false in br_mrp_enabled()
  2020-05-06  6:16 [PATCH net-next] net: bridge: return false in br_mrp_enabled() Jason Yan
@ 2020-05-06  9:47 ` Nikolay Aleksandrov
  2020-05-06 20:57 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Nikolay Aleksandrov @ 2020-05-06  9:47 UTC (permalink / raw)
  To: Jason Yan, roopa, davem, kuba, bridge, netdev, linux-kernel

On 06/05/2020 09:16, Jason Yan wrote:
> Fix the following coccicheck warning:
> 
> net/bridge/br_private.h:1334:8-9: WARNING: return of 0/1 in function
> 'br_mrp_enabled' with return type bool
> 
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>  net/bridge/br_private.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
> index c35647cb138a..78d3a951180d 100644
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -1331,7 +1331,7 @@ static inline int br_mrp_process(struct net_bridge_port *p, struct sk_buff *skb)
>  
>  static inline bool br_mrp_enabled(struct net_bridge *br)
>  {
> -	return 0;
> +	return false;
>  }
>  
>  static inline void br_mrp_port_del(struct net_bridge *br,
> 
Fixes: 6536993371fab ("bridge: mrp: Integrate MRP into the bridge")
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: bridge: return false in br_mrp_enabled()
  2020-05-06  6:16 [PATCH net-next] net: bridge: return false in br_mrp_enabled() Jason Yan
  2020-05-06  9:47 ` Nikolay Aleksandrov
@ 2020-05-06 20:57 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-05-06 20:57 UTC (permalink / raw)
  To: yanaijie; +Cc: roopa, nikolay, kuba, bridge, netdev, linux-kernel

From: Jason Yan <yanaijie@huawei.com>
Date: Wed, 6 May 2020 14:16:16 +0800

> Fix the following coccicheck warning:
> 
> net/bridge/br_private.h:1334:8-9: WARNING: return of 0/1 in function
> 'br_mrp_enabled' with return type bool
> 
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-06 20:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06  6:16 [PATCH net-next] net: bridge: return false in br_mrp_enabled() Jason Yan
2020-05-06  9:47 ` Nikolay Aleksandrov
2020-05-06 20:57 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).