linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: SeongJae Park <sjpark@amazon.com>
To: David Miller <davem@davemloft.net>
Cc: <sjpark@amazon.com>, <viro@zeniv.linux.org.uk>, <kuba@kernel.org>,
	<gregkh@linuxfoundation.org>, <edumazet@google.com>,
	<sj38.park@gmail.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <sjpark@amazon.de>
Subject: Re: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change
Date: Wed, 6 May 2020 08:24:23 +0200	[thread overview]
Message-ID: <20200506062423.28873-1-sjpark@amazon.com> (raw)
In-Reply-To: <20200505.120049.635223866062154775.davem@davemloft.net> (raw)

On Tue, 05 May 2020 12:00:49 -0700 (PDT) David Miller <davem@davemloft.net> wrote:

> From: David Miller <davem@davemloft.net>
> Date: Tue, 05 May 2020 11:48:25 -0700 (PDT)
> 
> > Series applied and queued up for -stable, thanks.
> 
> Nevermind, this doesn't even compile.
> 
> net/smc/af_smc.c: In function ‘smc_switch_to_fallback’:
> net/smc/af_smc.c:473:19: error: ‘smc->clcsock->wq’ is a pointer; did you mean to use ‘->’?
>   473 |   smc->clcsock->wq.fasync_list =
>       |                   ^
>       |                   ->
> net/smc/af_smc.c:474:25: error: ‘smc->sk.sk_socket->wq’ is a pointer; did you mean to use ‘->’?
>   474 |    smc->sk.sk_socket->wq.fasync_list;
>       |                         ^
>       |                         ->
> 
> So I had to revert these changes.
> 
> When you make a change of this magnitude and scope you must do an
> allmodconfig build.

Definitely my fault.  I will fix this in next spin.


Thanks,
SeongJae Park

> 
> Thank you.

      reply	other threads:[~2020-05-06  6:25 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05  8:10 [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change SeongJae Park
2020-05-05  8:10 ` [PATCH net v2 1/2] Revert "coallocate socket_wq with socket itself" SeongJae Park
2020-05-06  4:55   ` kbuild test robot
2020-05-05  8:10 ` [PATCH net v2 2/2] Revert "sockfs: switch to ->free_inode()" SeongJae Park
2020-05-05 11:54 ` [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change SeongJae Park
2020-05-05 12:31   ` Nuernberger, Stefan
2020-05-05 14:53   ` Eric Dumazet
2020-05-05 15:07     ` SeongJae Park
2020-05-05 15:20       ` Eric Dumazet
2020-05-05 15:46         ` SeongJae Park
2020-05-05 16:00           ` Eric Dumazet
2020-05-05 16:13             ` SeongJae Park
2020-05-05 16:25               ` Eric Dumazet
2020-05-05 16:31                 ` Eric Dumazet
2020-05-05 16:37                   ` Eric Dumazet
2020-05-05 17:05                     ` SeongJae Park
2020-05-05 17:30                       ` Paul E. McKenney
2020-05-05 17:56                         ` SeongJae Park
2020-05-05 18:17                           ` Paul E. McKenney
2020-05-05 18:34                             ` SeongJae Park
2020-05-05 18:49                               ` Paul E. McKenney
2020-05-06 12:59                                 ` SeongJae Park
2020-05-06 14:33                                   ` Eric Dumazet
2020-05-06 14:41                                   ` Paul E. McKenney
2020-05-06 15:20                                     ` SeongJae Park
2020-05-05 17:28                     ` Paul E. McKenney
2020-05-05 18:11                       ` SeongJae Park
2020-05-05 17:23                 ` Paul E. McKenney
2020-05-05 17:49                   ` SeongJae Park
2020-05-05 18:27                     ` Paul E. McKenney
2020-05-05 18:40                       ` SeongJae Park
2020-05-05 18:48                         ` Paul E. McKenney
2020-05-05 16:26             ` Al Viro
2020-05-05 18:48 ` David Miller
2020-05-05 19:00   ` David Miller
2020-05-06  6:24     ` SeongJae Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200506062423.28873-1-sjpark@amazon.com \
    --to=sjpark@amazon.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sj38.park@gmail.com \
    --cc=sjpark@amazon.de \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).