From: Sudeep Holla <sudeep.holla@arm.com>
To: Hanjun Guo <guohanjun@huawei.com>
Cc: Xiongfeng Wang <wangxiongfeng2@huawei.com>,
rjw@rjwysocki.net, viresh.kumar@linaro.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
john.garry@huawei.com,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Souvik Chakravarty <Souvik.Chakravarty@arm.com>,
Thanu Rangarajan <Thanu.Rangarajan@arm.com>
Subject: Re: [RFC PATCH] cpufreq: add support for HiSilicon SoC HIP09
Date: Wed, 6 May 2020 13:49:32 +0100 [thread overview]
Message-ID: <20200506124932.GA20426@bogus> (raw)
In-Reply-To: <3ba950dd-4065-e4a5-d406-dc5c6c1781a7@huawei.com>
+ Thanu, Souvik who work with ASWG
On Wed, May 06, 2020 at 05:36:51PM +0800, Hanjun Guo wrote:
> Hi Sudeep,
>
> On 2020/4/30 17:55, Sudeep Holla wrote:
> > On Thu, Apr 30, 2020 at 02:19:59PM +0800, Xiongfeng Wang wrote:
> > > HiSilicon SoC has a separate System Control Processor(SCP) dedicated for
> > > clock frequency adjustment and has been using the cpufreq driver
> > > 'cppc-cpufreq'. New HiSilicon SoC HIP09 add support for CPU Boost, but
> > > ACPI CPPC doesn't support this. In HiSilicon SoC HIP09, each core has
> > > its own clock domain. It is better for the core itself to adjust its
> > > frequency when we require fast response. In this patch, we add a
> > > separate cpufreq driver for HiSilicon SoC HIP09.
> > >
> >
> > I disagree with this approach unless you have tried to extend the CPPC
> > in ACPI to accommodate this boost feature you need. Until you show those
> > efforts and disagreement to do that from ASWG, I am NACKing this approach.
>
> Unfortunately we are not in ASWG at now, could you please give some
> help about extending CPPC in ACPI to support boost feature?
>
You may have to provide more details than the commit log for sure as I
haven't understood the boost feature and what is missing in ACPI CPPC.
--
Regards,
Sudeep
next prev parent reply other threads:[~2020-05-06 12:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 6:19 [RFC PATCH] cpufreq: add support for HiSilicon SoC HIP09 Xiongfeng Wang
2020-04-30 9:55 ` Sudeep Holla
2020-05-05 2:12 ` Xiongfeng Wang
2020-05-06 9:36 ` Hanjun Guo
2020-05-06 12:49 ` Sudeep Holla [this message]
2020-05-06 12:58 ` Thanu Rangarajan
2020-05-06 14:57 ` Souvik Chakravarty
2020-05-07 13:04 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506124932.GA20426@bogus \
--to=sudeep.holla@arm.com \
--cc=Souvik.Chakravarty@arm.com \
--cc=Thanu.Rangarajan@arm.com \
--cc=guohanjun@huawei.com \
--cc=john.garry@huawei.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
--cc=wangxiongfeng2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).