From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54938C47256 for ; Wed, 6 May 2020 15:54:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33551208DB for ; Wed, 6 May 2020 15:54:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729789AbgEFPyl (ORCPT ); Wed, 6 May 2020 11:54:41 -0400 Received: from fieldses.org ([173.255.197.46]:47730 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728991AbgEFPyl (ORCPT ); Wed, 6 May 2020 11:54:41 -0400 Received: by fieldses.org (Postfix, from userid 2815) id 8876B1507; Wed, 6 May 2020 11:54:40 -0400 (EDT) Date: Wed, 6 May 2020 11:54:40 -0400 From: "J. Bruce Fields" To: Tejun Heo Cc: "J. Bruce Fields" , Linus Torvalds , "open list:NFS, SUNRPC, AND..." , Jeff Layton , David Howells , Shaohua Li , Oleg Nesterov , Linux Kernel Mailing List Subject: Re: [PATCH 0/4] allow multiple kthreadd's Message-ID: <20200506155440.GB21307@fieldses.org> References: <1588348912-24781-1-git-send-email-bfields@redhat.com> <20200501182154.GG5462@mtj.thefacebook.com> <20200505021514.GA43625@pick.fieldses.org> <20200505210118.GC27966@fieldses.org> <20200505210956.GA3350@mtj.thefacebook.com> <20200505212527.GA1265@fieldses.org> <20200506153658.GA21307@fieldses.org> <20200506153920.GB3350@mtj.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200506153920.GB3350@mtj.thefacebook.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 06, 2020 at 11:39:20AM -0400, Tejun Heo wrote: > Hello, Bruce. > > On Wed, May 06, 2020 at 11:36:58AM -0400, J. Bruce Fields wrote: > > On Tue, May 05, 2020 at 05:25:27PM -0400, J. Bruce Fields wrote: > > > On Tue, May 05, 2020 at 05:09:56PM -0400, Tejun Heo wrote: > > > > It's not the end of the world but a bit hacky. I wonder whether something > > > > like the following would work better for identifying worker type so that you > > > > can do sth like > > > > > > > > if (kthread_fn(current) == nfsd) > > > > return kthread_data(current); > > > > else > > > > return NULL; > > > > > > Yes, definitely more generic, looks good to me. > > > > This is what I'm testing with. > > > > If it's OK with you, could I add your Signed-off-by and take it through > > the nfsd tree? I'll have some other patches that will depend on it. > > Please feel free to use the code however you see fit. Given that it'll be > originating from you, my signed-off-by might not be the right tag. Something > like Original-patch-by should be good (nothing is fine too). OK, I'll do that, thanks! --b.