From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Calvin Johnson <calvin.johnson@oss.nxp.com>
Cc: Mike Leach <mike.leach@linaro.org>,
linux.cj@gmail.com,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coresight: cti: remove incorrect NULL return check
Date: Wed, 6 May 2020 11:05:31 -0600 [thread overview]
Message-ID: <20200506170531.GA29826@xps15> (raw)
In-Reply-To: <20200505134020.11148-1-calvin.johnson@oss.nxp.com>
On Tue, May 05, 2020 at 07:10:20PM +0530, Calvin Johnson wrote:
> fwnode_find_reference() doesn't return NULL and hence that check
> should be avoided.
>
> Signed-off-by: Calvin Johnson <calvin.johnson@oss.nxp.com>
> ---
>
> drivers/hwtracing/coresight/coresight-cti-platform.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-cti-platform.c b/drivers/hwtracing/coresight/coresight-cti-platform.c
> index b44d83142b62..2fdaeec80ee5 100644
> --- a/drivers/hwtracing/coresight/coresight-cti-platform.c
> +++ b/drivers/hwtracing/coresight/coresight-cti-platform.c
> @@ -120,7 +120,7 @@ static int cti_plat_create_v8_etm_connection(struct device *dev,
>
> /* Can optionally have an etm node - return if not */
> cs_fwnode = fwnode_find_reference(root_fwnode, CTI_DT_CSDEV_ASSOC, 0);
> - if (IS_ERR_OR_NULL(cs_fwnode))
> + if (IS_ERR(cs_fwnode))
> return 0;
>
> /* allocate memory */
> @@ -393,7 +393,7 @@ static int cti_plat_create_connection(struct device *dev,
> /* associated device ? */
> cs_fwnode = fwnode_find_reference(fwnode,
> CTI_DT_CSDEV_ASSOC, 0);
> - if (!IS_ERR_OR_NULL(cs_fwnode)) {
> + if (!IS_ERR(cs_fwnode)) {
> assoc_name = cti_plat_get_csdev_or_node_name(cs_fwnode,
> &csdev);
You are correct.
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Greg, can you pick this up as a fix for 5.7?
Thanks,
Mathieu
> fwnode_handle_put(cs_fwnode);
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-05-06 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 13:40 [PATCH] coresight: cti: remove incorrect NULL return check Calvin Johnson
2020-05-06 17:05 ` Mathieu Poirier [this message]
2020-05-07 5:35 Calvin Johnson
2020-05-12 18:00 ` Mathieu Poirier
2020-05-15 14:22 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506170531.GA29826@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=calvin.johnson@oss.nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.cj@gmail.com \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).