linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maninder Singh <maninder1.s@samsung.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: "George G. Davis" <george_davis@mentor.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	AMIT SAHRAWAT <a.sahrawat@samsung.com>,
	Vaneet Narang <v.narang@samsung.com>
Subject: RE:[PATCH 4/4] scripts/checkstack.pl: fix arm sp regex
Date: Thu, 07 May 2020 16:21:22 +0530	[thread overview]
Message-ID: <20200507105122epcms5p543853209caaec4c3b031d64f916f9ccc@epcms5p5> (raw)
In-Reply-To: <CAK7LNASf687MLf1oWqrUiOHtw=p9Ug02bi1r-KevsxnFtQni2g@mail.gmail.com>

Hi Masahiro,

Thanks for review.
We will integrate your review comements and send v2.

>>

>> so making regex $re for ARM similar to aarch64
>>
>> Signed-off-by: Vaneet Narang <v.narang@samsung.com>
>> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> 
> 
>This looks good to me, and it is a bug fix.
> 
>Just a question about the SOB.
> 
> 
>Maninder Singh is the author and also the submitter, right?
> 
>What does "Signed-off-by: Vaneet Narang <v.narang@samsung.com>" mean?
> 
>Co-developed-by or something else?
 
Yes All 4 patches are co-developed by Vaneet and me.
we were checking stack usage for arm and AARCH64 and found
some changes in scrips which can help others also.

Thanks,
Maninder Singh

  parent reply	other threads:[~2020-05-07 11:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200430124952epcas5p28cd53b0aa452f43eed48ed9d58b4005b@epcas5p2.samsung.com>
2020-04-30 12:49 ` [PATCH 1/4] scripts/checkstack.pl: don't display $dre as different entity Maninder Singh
     [not found]   ` <CGME20200430124955epcas5p4b5c1dd7393a7b798d80206d071264df3@epcas5p4.samsung.com>
2020-04-30 12:49     ` [PATCH 2/4] scripts/checkstack.pl: Add argument to print stacks greather than value Maninder Singh
2020-05-07  8:13       ` Masahiro Yamada
     [not found]   ` <CGME20200430124958epcas5p15ecc8e744ed0f78837a6d58274a5baf0@epcas5p1.samsung.com>
2020-04-30 12:49     ` [PATCH 3/4] scripts/checkstack.pl: add arm push handling for stack usage Maninder Singh
2020-05-07 10:35       ` Masahiro Yamada
     [not found]       ` <CGME20200430124958epcas5p15ecc8e744ed0f78837a6d58274a5baf0@epcms5p8>
2020-05-07 13:32         ` Vaneet Narang
     [not found]   ` <CGME20200430125001epcas5p2a6f02e9888481cef96f32ba14450bc63@epcas5p2.samsung.com>
2020-04-30 12:49     ` [PATCH 4/4] scripts/checkstack.pl: fix arm sp regex Maninder Singh
2020-05-07 10:38       ` Masahiro Yamada
     [not found]       ` <CGME20200430125001epcas5p2a6f02e9888481cef96f32ba14450bc63@epcms5p5>
2020-05-07 10:51         ` Maninder Singh [this message]
2020-05-07 11:58           ` Masahiro Yamada
2020-05-07  8:12   ` [PATCH 1/4] scripts/checkstack.pl: don't display $dre as different entity Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200507105122epcms5p543853209caaec4c3b031d64f916f9ccc@epcms5p5 \
    --to=maninder1.s@samsung.com \
    --cc=a.sahrawat@samsung.com \
    --cc=george_davis@mentor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=v.narang@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).