From: Kees Cook <keescook@chromium.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Benson Leung <bleung@google.com>,
Guenter Roeck <groeck@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
Sarthak Kukreti <sarthakkukreti@chromium.org>
Subject: Re: linux-next: manual merge of the chrome-platform tree with the pstore tree
Date: Thu, 7 May 2020 10:56:22 -0700 [thread overview]
Message-ID: <202005071056.F83305E0@keescook> (raw)
In-Reply-To: <20200507145547.7c514106@canb.auug.org.au>
On Thu, May 07, 2020 at 02:55:47PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next merge of the chrome-platform tree got a conflict in:
>
> drivers/platform/chrome/chromeos_pstore.c
>
> between commit:
>
> 7bddec15c574 ("pstore/ram: Introduce max_reason and convert dump_oops")
>
> from the pstore tree and commit:
>
> 1c7c51347f2e ("platform/chrome: chromeos_pstore: set user space log size")
>
> from the chrome-platform tree.
>
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging. You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
>
> --
> Cheers,
> Stephen Rothwell
>
> diff --cc drivers/platform/chrome/chromeos_pstore.c
> index fa51153688b4,82dea8cb5da1..000000000000
> --- a/drivers/platform/chrome/chromeos_pstore.c
> +++ b/drivers/platform/chrome/chromeos_pstore.c
> @@@ -57,7 -57,8 +57,8 @@@ static struct ramoops_platform_data chr
> .record_size = 0x40000,
> .console_size = 0x20000,
> .ftrace_size = 0x20000,
> + .pmsg_size = 0x20000,
> - .dump_oops = 1,
> + .max_reason = KMSG_DUMP_OOPS,
> };
>
> static struct platform_device chromeos_ramoops = {
Thanks! Yes, that looks correct.
--
Kees Cook
prev parent reply other threads:[~2020-05-07 17:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 4:55 linux-next: manual merge of the chrome-platform tree with the pstore tree Stephen Rothwell
2020-05-07 17:56 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202005071056.F83305E0@keescook \
--to=keescook@chromium.org \
--cc=bleung@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=sarthakkukreti@chromium.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).