From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9117DC38A24 for ; Thu, 7 May 2020 18:04:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71720215A4 for ; Thu, 7 May 2020 18:04:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="mvyOT1Ef" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728336AbgEGSEh (ORCPT ); Thu, 7 May 2020 14:04:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728073AbgEGSEf (ORCPT ); Thu, 7 May 2020 14:04:35 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BB22C05BD09 for ; Thu, 7 May 2020 11:04:35 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id b8so2821697pgi.11 for ; Thu, 07 May 2020 11:04:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oPdDzYdT7lq792vB2W2IICBi0aPxUsQi5JdgRLaM8DE=; b=mvyOT1EfMtTIMiyqWwuFA04fPAW6A3fhyPcQYaNMProcOmtHYJb+m3xgi4wA3jLajJ 0/+FxWryJeRpZO6qoIDw8HCGDcluMT5vD6KSyflLwL4sWR4NWkx/CTjAMPrjcD9Qo+LL yXfNX0vri2Wv4UK70vKw8jXT4Kx/RlaYek7TY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oPdDzYdT7lq792vB2W2IICBi0aPxUsQi5JdgRLaM8DE=; b=WTXU2LjVEhnXfQcTWe1YamtobxLqLcsd1WyNOcoRjb6NwoxU0trtwI/viaeOO0rGFr XhQJ4x4Hn2cS9Iz50CdRiy5Z+GDNbQauDctkosdHpsEk+gfDKx5Yebb9Nm8Hp5NPc9ZH 7fOvz8xprWRcTP0b/bZDGUypPIvCflZcRMtuYhqJNjWLI6whTs8bWRRW1UEhWwCiKhF9 GKNIAE8m1x4JLrgA0nl64wWhdWBI7xJVMOmKnlSu8lWP15fSlh6JIYlN7uMV64Ob3s1s PbZK0uMVogdh0kVkZg1nQFwggbmSlrxYwjHUfpmbeGdZwckbuRbK9OCNFDbmLr0jUAe0 /BLg== X-Gm-Message-State: AGi0PuYer1cw/smTMFveWyZ9RKGklOzGik4fsOswIdyifkzpKQw4Vekn LLbaO0RSRbTbuawpxkKgGLEbCg== X-Google-Smtp-Source: APiQypKvA1tcaT6o5w99vrDSSQJendwU+OBaqZIhGVGhaS/hGCH2qmFU6zieh7bYSXERa2QoSC5VMA== X-Received: by 2002:a62:b514:: with SMTP id y20mr14582234pfe.49.1588874674588; Thu, 07 May 2020 11:04:34 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id q21sm5547240pfg.131.2020.05.07.11.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2020 11:04:33 -0700 (PDT) Date: Thu, 7 May 2020 11:04:32 -0700 From: Kees Cook To: Pavel Tatashin Cc: Anton Vorontsov , Colin Cross , Tony Luck , Jonathan Corbet , Rob Herring , Benson Leung , Enric Balletbo i Serra , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , James Morris , Sasha Levin , Linux Doc Mailing List , LKML , devicetree@vger.kernel.org Subject: Re: [PATCH v3 3/6] pstore/ram: Refactor DT size parsing Message-ID: <202005071103.EDD880257@keescook> References: <20200506211523.15077-1-keescook@chromium.org> <20200506211523.15077-4-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 07, 2020 at 08:57:50AM -0400, Pavel Tatashin wrote: > On Wed, May 6, 2020 at 5:15 PM Kees Cook wrote: > > > > Refactor device tree size parsing routines to be able to pass a non-zero > > default value for providing a configurable default for the coming > > "max_reason" field. > > > > Signed-off-by: Kees Cook > > ramoops_parse_dt_size > parse_size > > Are used to parse flags, and max-reason properties, so the "size" in > their names become outdated. How about: > ramoops_parse_dt_prop > parse_prop Yeah, I struggled with that thought too. > Otherwise it looks good. Okay, great, I'll find a better name and apply this series. Thanks! -- Kees Cook