Re: [PATCH v12 02/10] KVM: VMX: Set guest CET MSRs per KVM and host configuration

From: kbuild test robot <lkp@intel.com>
To: Yang Weijiang <weijiang.yang@intel.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	pbonzini@redhat.com, sean.j.christopherson@intel.com,
	jmattson@google.com
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	yu.c.zhang@linux.intel.com,
	Yang Weijiang <weijiang.yang@intel.com>
Subject: Re: [PATCH v12 02/10] KVM: VMX: Set guest CET MSRs per KVM and host configuration
Date: Thu, 7 May 2020 13:54:46 +0800	[thread overview]
Message-ID: <202005071343.zDdGYa6z%lkp@intel.com> (raw)
In-Reply-To: <20200506082110.25441-3-weijiang.yang@intel.com>

[-- Attachment #1: Type: text/plain, Size: 5299 bytes --]

Hi Yang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on vhost/linux-next]
[also build test ERROR on tip/auto-latest linus/master v5.7-rc4 next-20200505]
[cannot apply to kvm/linux-next linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Yang-Weijiang/Introduce-support-for-guest-CET-feature/20200507-021021
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 54b35c066417d4856e9d53313f7e98b354274584)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> arch/x86/kvm/vmx/vmx.c:3026:26: error: use of undeclared identifier 'X86_FEATURE_SHSTK'; did you mean 'XFEATURE_SSE'?
                   (guest_cpuid_has(vcpu, X86_FEATURE_SHSTK) ||
                                          ^~~~~~~~~~~~~~~~~
                                          XFEATURE_SSE
   arch/x86/include/asm/fpu/types.h:104:2: note: 'XFEATURE_SSE' declared here
           XFEATURE_SSE,
           ^
   arch/x86/kvm/vmx/vmx.c:3027:25: error: use of undeclared identifier 'X86_FEATURE_IBT'
                   guest_cpuid_has(vcpu, X86_FEATURE_IBT)));
                                         ^
   arch/x86/kvm/vmx/vmx.c:7114:40: error: use of undeclared identifier 'XFEATURE_MASK_CET_USER'
           incpt = !is_cet_state_supported(vcpu, XFEATURE_MASK_CET_USER);
                                                 ^
>> arch/x86/kvm/vmx/vmx.c:7119:40: error: use of undeclared identifier 'MSR_IA32_U_CET'
           vmx_set_intercept_for_msr(msr_bitmap, MSR_IA32_U_CET, MSR_TYPE_RW,
                                                 ^
>> arch/x86/kvm/vmx/vmx.c:7121:40: error: use of undeclared identifier 'MSR_IA32_PL3_SSP'
           vmx_set_intercept_for_msr(msr_bitmap, MSR_IA32_PL3_SSP, MSR_TYPE_RW,
                                                 ^
   arch/x86/kvm/vmx/vmx.c:7124:40: error: use of undeclared identifier 'XFEATURE_MASK_CET_KERNEL'
           incpt = !is_cet_state_supported(vcpu, XFEATURE_MASK_CET_KERNEL);
                                                 ^
>> arch/x86/kvm/vmx/vmx.c:7129:40: error: use of undeclared identifier 'MSR_IA32_S_CET'
           vmx_set_intercept_for_msr(msr_bitmap, MSR_IA32_S_CET, MSR_TYPE_RW,
                                                 ^
>> arch/x86/kvm/vmx/vmx.c:7131:40: error: use of undeclared identifier 'MSR_IA32_PL0_SSP'
           vmx_set_intercept_for_msr(msr_bitmap, MSR_IA32_PL0_SSP, MSR_TYPE_RW,
                                                 ^
>> arch/x86/kvm/vmx/vmx.c:7133:40: error: use of undeclared identifier 'MSR_IA32_PL1_SSP'
           vmx_set_intercept_for_msr(msr_bitmap, MSR_IA32_PL1_SSP, MSR_TYPE_RW,
                                                 ^
>> arch/x86/kvm/vmx/vmx.c:7135:40: error: use of undeclared identifier 'MSR_IA32_PL2_SSP'
           vmx_set_intercept_for_msr(msr_bitmap, MSR_IA32_PL2_SSP, MSR_TYPE_RW,
                                                 ^
   arch/x86/kvm/vmx/vmx.c:7138:34: error: use of undeclared identifier 'X86_FEATURE_SHSTK'; did you mean 'XFEATURE_SSE'?
           incpt |= !guest_cpuid_has(vcpu, X86_FEATURE_SHSTK);
                                           ^~~~~~~~~~~~~~~~~
                                           XFEATURE_SSE
   arch/x86/include/asm/fpu/types.h:104:2: note: 'XFEATURE_SSE' declared here
           XFEATURE_SSE,
           ^
>> arch/x86/kvm/vmx/vmx.c:7140:40: error: use of undeclared identifier 'MSR_IA32_INT_SSP_TAB'
           vmx_set_intercept_for_msr(msr_bitmap, MSR_IA32_INT_SSP_TAB, MSR_TYPE_RW,
                                                 ^
   arch/x86/kvm/vmx/vmx.c:7183:23: error: use of undeclared identifier 'XFEATURE_MASK_CET_KERNEL'
           if (supported_xss & (XFEATURE_MASK_CET_KERNEL | XFEATURE_MASK_CET_USER))
                                ^
   arch/x86/kvm/vmx/vmx.c:7183:50: error: use of undeclared identifier 'XFEATURE_MASK_CET_USER'
           if (supported_xss & (XFEATURE_MASK_CET_KERNEL | XFEATURE_MASK_CET_USER))
                                                           ^
   14 errors generated.

vim +3026 arch/x86/kvm/vmx/vmx.c

  3022	
  3023	static bool is_cet_state_supported(struct kvm_vcpu *vcpu, u32 xss_states)
  3024	{
  3025		return ((supported_xss & xss_states) &&
> 3026			(guest_cpuid_has(vcpu, X86_FEATURE_SHSTK) ||
  3027			guest_cpuid_has(vcpu, X86_FEATURE_IBT)));
  3028	}
  3029	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 73469 bytes --]