From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19C9BC47247 for ; Thu, 7 May 2020 22:56:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC4C8208CA for ; Thu, 7 May 2020 22:56:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588892213; bh=DFVZVtjOy5Zq82K7JozE2r2KIIrkXMdk+V1nGag44c4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=k4T5syPhthUyfLDcS6NjtpgUX5K+6nxkKQJenLYCXeJI0h8PduGD0N5Bt2ZYC1M6Q ex5GjjCPqOw8SWLq/t6n1gobzD46GhqHUZlIrd4+ypfNSmllrLZLXJAHN8Geg1TYOs 4RQU8PbwUxqa3pSNhvNCNzjj/v8aAu8S0W5Q553Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727110AbgEGW4x (ORCPT ); Thu, 7 May 2020 18:56:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:52782 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726515AbgEGW4w (ORCPT ); Thu, 7 May 2020 18:56:52 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B888A2083B; Thu, 7 May 2020 22:56:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588892212; bh=DFVZVtjOy5Zq82K7JozE2r2KIIrkXMdk+V1nGag44c4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cfWvMsu2a/TSPk7q/+Zmfy29Q+AC9QWezN1eQf99G/LyIFEochDHBbNGHvRrHDHwd SZglIFhyk6ytKrqx4WYehFbADUTk/TTe7OKAqe6BCfjM+R6c6vfSj6H2Ogxrf/0GT4 qWEFvrGtflMZ2XaXUvIx5uz56muVQ9+ZoWAD9EJ0= Date: Thu, 7 May 2020 15:56:50 -0700 From: Jakub Kicinski To: Bartosz Golaszewski Cc: Bartosz Golaszewski , Rob Herring , "David S . Miller" , Matthias Brugger , John Crispin , Sean Wang , Mark Lee , Arnd Bergmann , Fabien Parent , devicetree , Linux Kernel Mailing List , netdev , Linux ARM , linux-mediatek@lists.infradead.org, Heiner Kallweit Subject: Re: [PATCH 05/11] net: core: provide devm_register_netdev() Message-ID: <20200507155650.0c19229e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20200505140231.16600-1-brgl@bgdev.pl> <20200505140231.16600-6-brgl@bgdev.pl> <20200505103105.1c8b0ce3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200506101236.25a13609@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200507095315.1154a1a6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 7 May 2020 19:03:44 +0200 Bartosz Golaszewski wrote: >> To implement Edwin's suggestion? Makes sense, but I'm no expert, let's >> also CC Heiner since he was asking about it last time. =20 >=20 > Yes, because taking the last bit of priv_flags from net_device seems > to be more controversial but if net maintainers are fine with that I > can simply go with the current approach. =46rom my perspective what Edwin suggests makes sense. Apart from little use for the bit after probe, it also seems cleaner for devres=20 to be able to recognize managed objects based on its own state.