From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDB8EC38A2A for ; Thu, 7 May 2020 21:32:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C848A2054F for ; Thu, 7 May 2020 21:32:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726565AbgEGVca (ORCPT ); Thu, 7 May 2020 17:32:30 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:38628 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726320AbgEGVc2 (ORCPT ); Thu, 7 May 2020 17:32:28 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 7CEDE803087C; Thu, 7 May 2020 21:32:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fl9KsNoMQI8f; Fri, 8 May 2020 00:32:24 +0300 (MSK) Date: Fri, 8 May 2020 00:32:22 +0300 From: Serge Semin To: Thomas Bogendoerfer CC: Serge Semin , Ralf Baechle , Markos Chandras , Alexey Malahov , Paul Burton , Arnd Bergmann , Rob Herring , , , Allison Randal , Greg Kroah-Hartman , Thomas Gleixner , , Subject: Re: [PATCH v2 04/20] mips: cm: Fix an invalid error code of INTVN_*_ERR Message-ID: <20200507213222.ju3qeb27ml22omej@mobilestation> References: <20200306124807.3596F80307C2@mail.baikalelectronics.ru> <20200506174238.15385-1-Sergey.Semin@baikalelectronics.ru> <20200506174238.15385-5-Sergey.Semin@baikalelectronics.ru> <20200507111007.GE11616@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200507111007.GE11616@alpha.franken.de> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 07, 2020 at 01:10:07PM +0200, Thomas Bogendoerfer wrote: > On Wed, May 06, 2020 at 08:42:22PM +0300, Sergey.Semin@baikalelectronics.ru wrote: > > From: Serge Semin > > > > Commit 3885c2b463f6 ("MIPS: CM: Add support for reporting CM cache > > errors") adds cm2_causes[] array with map of error type ID and > > pointers to the short description string. There is a mistake in > > the table, since according to MIPS32 manual CM2_ERROR_TYPE = {17,18} > > correspond to INTVN_WR_ERR and INTVN_RD_ERR, while the table > > claims they have {0x17,0x18} codes. This is obviously hex-dec > > copy-paste bug. Moreover codes {0x18 - 0x1a} indicate L2 ECC errors. > > > > Fixes: 3885c2b463f6 ("MIPS: CM: Add support for reporting CM cache errors") > > Signed-off-by: Serge Semin > > Cc: Alexey Malahov > > Cc: Thomas Bogendoerfer > > Cc: Paul Burton > > Cc: Ralf Baechle > > Cc: Arnd Bergmann > > Cc: Rob Herring > > Cc: linux-pm@vger.kernel.org > > Cc: devicetree@vger.kernel.org > > --- > > arch/mips/kernel/mips-cm.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > applied to mips-next. Great! Thanks. -Sergey > > Thomas. > > -- > Crap can work. Given enough thrust pigs will fly, but it's not necessarily a > good idea. [ RFC1925, 2.3 ]