From: Steven Rostedt <rostedt@goodmis.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
jeyu@kernel.org, akpm@linux-foundation.org, arnd@arndb.de,
mingo@redhat.com, aquini@redhat.com, cai@lca.pw,
dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org,
tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com,
tiwai@suse.de, schlad@suse.de, keescook@chromium.org,
daniel.vetter@ffwll.ch, will@kernel.org,
mchehab+samsung@kernel.org, kvalo@codeaurora.org,
davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [RFC] taint: add module firmware crash taint support
Date: Fri, 8 May 2020 09:49:45 -0400 [thread overview]
Message-ID: <20200508094923.2ab9014a@gandalf.local.home> (raw)
In-Reply-To: <20200508101604.GF185537@smile.fi.intel.com>
On Fri, 8 May 2020 13:16:04 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > +++ b/include/trace/events/module.h
> > @@ -26,7 +26,8 @@ struct module;
> > { (1UL << TAINT_OOT_MODULE), "O" }, \
> > { (1UL << TAINT_FORCED_MODULE), "F" }, \
> > { (1UL << TAINT_CRAP), "C" }, \
> > - { (1UL << TAINT_UNSIGNED_MODULE), "E" })
> > + { (1UL << TAINT_UNSIGNED_MODULE), "E" }, \
> > + { (1UL << TAINT_FIRMWARE_CRASH), "Q" })
>
> Perhaps split out the closing parenthesis to avoid changing additional line in
> the future?
I don't think that will make a difference, as the last line must not
contain a comma. New updates will still add additional line changes just to
insert a comma before adding a new flag.
-- Steve
>
> > TRACE_EVENT(module_load,
next prev parent reply other threads:[~2020-05-08 13:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 2:14 [RFC] taint: add module firmware crash taint support Luis Chamberlain
2020-05-08 2:18 ` Luis Chamberlain
2020-05-08 5:47 ` Kees Cook
2020-05-08 6:04 ` Luis Chamberlain
2020-05-08 6:11 ` Daniel Vetter
2020-05-08 6:24 ` Luis Chamberlain
2020-05-08 10:16 ` Andy Shevchenko
2020-05-08 13:49 ` Steven Rostedt [this message]
2020-05-08 14:04 ` Rafael Aquini
2020-05-08 15:37 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508094923.2ab9014a@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aquini@redhat.com \
--cc=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=cai@lca.pw \
--cc=daniel.vetter@ffwll.ch \
--cc=davem@davemloft.net \
--cc=dyoung@redhat.com \
--cc=gpiccoli@canonical.com \
--cc=jeyu@kernel.org \
--cc=keescook@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=schlad@suse.de \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).