From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC15EC47254 for ; Fri, 8 May 2020 12:02:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE05E21582 for ; Fri, 8 May 2020 12:02:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588939329; bh=MVgAInBlHbFucqqOMS2zpzCl41mt8McPbpWInuTvt7A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Zty6mMK7BYeOKVpTze3XEERDmPeWBu9vb2gGACEM7RSILKyLDvAiwU8osIIiIdxTk 0a6cS1tSOi+uERU0zO85oFltQK8TY1Dnw5ejDuYzYempgGVoQ3vO2L3TOQif99aQEl ag6fI9LnaxW0f4lOUti5xxDeHoI95WF8WB+7E9lI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727107AbgEHMCJ (ORCPT ); Fri, 8 May 2020 08:02:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:48438 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726618AbgEHMCI (ORCPT ); Fri, 8 May 2020 08:02:08 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 44B0B208DB; Fri, 8 May 2020 12:02:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588939327; bh=MVgAInBlHbFucqqOMS2zpzCl41mt8McPbpWInuTvt7A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Twetzls2F3Jeu+KmG5FUOutvjCz/WoqfrsBaX8GvAALNLGFDnKHPy8LdLPUulm0yK tBOfN6D3JwamP0kQgp3199ol6mSEtcR3ZeMDY8UHhllndREBSrWk/ouW1UclYwkLr1 L125iRZ6ei661Ah3Bz5HYH2pfNhM462Cs2rBmyg0= Date: Fri, 8 May 2020 14:02:05 +0200 From: Greg Kroah-Hartman To: Johan Hovold Cc: Naresh Kamboju , linux- stable , Sasha Levin , "David S. Miller" , Florian Fainelli , Fugang Duan , Pantelis Antoniou , Thomas Petazzoni , Matthias Brugger , Sergei Shtylyov , Lars Persson , Grygorii Strashko , Rob Herring , Frank Rowand , Andrew Lunn , Netdev , nios2-dev@lists.rocketboards.org, open list , linuxppc-dev@lists.ozlabs.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-omap@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , lkft-triage@lists.linaro.org Subject: Re: [PATCH net 11/16] net: ethernet: marvell: mvneta: fix fixed-link phydev leaks Message-ID: <20200508120205.GA4089177@kroah.com> References: <1480357509-28074-1-git-send-email-johan@kernel.org> <1480357509-28074-12-git-send-email-johan@kernel.org> <20200507064412.GL2042@localhost> <20200507064734.GA798308@kroah.com> <20200507111312.GA1497799@kroah.com> <20200508062119.GE25962@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200508062119.GE25962@localhost> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 08, 2020 at 08:21:19AM +0200, Johan Hovold wrote: > On Fri, May 08, 2020 at 03:35:02AM +0530, Naresh Kamboju wrote: > > On Thu, 7 May 2020 at 16:43, Greg Kroah-Hartman > > wrote: > > > > > > > > > > > > > > > Greg, 3f65047c853a ("of_mdio: add helper to deregister fixed-link > > > > > PHYs") needs to be backported as well for these. > > > > > > > > > > Original series can be found here: > > > > > > > > > > https://lkml.kernel.org/r/1480357509-28074-1-git-send-email-johan@kernel.org > > > > > > > > Ah, thanks for that, I thought I dropped all of the ones that caused > > > > build errors, but missed the above one. I'll go take the whole series > > > > instead. > > > > > > This should now all be fixed up, thanks. > > > > While building kernel Image for arm architecture on stable-rc 4.4 branch > > the following build error found. > > > > of_mdio: add helper to deregister fixed-link PHYs > > commit 3f65047c853a2a5abcd8ac1984af3452b5df4ada upstream. > > > > Add helper to deregister fixed-link PHYs registered using > > of_phy_register_fixed_link(). > > > > Convert the two drivers that care to deregister their fixed-link PHYs to > > use the new helper, but note that most drivers currently fail to do so. > > > > Signed-off-by: Johan Hovold > > Signed-off-by: David S. Miller > > [only take helper function for 4.4.y - gregkh] > > > > # make -sk KBUILD_BUILD_USER=TuxBuild -C/linux -j16 ARCH=arm > > CROSS_COMPILE=arm-linux-gnueabihf- HOSTCC=gcc CC="sccache > > arm-linux-gnueabihf-gcc" O=build zImage > > 70 # > > 71 ../drivers/of/of_mdio.c: In function ‘of_phy_deregister_fixed_link’: > > 72 ../drivers/of/of_mdio.c:379:2: error: implicit declaration of > > function ‘fixed_phy_unregister’; did you mean ‘fixed_phy_register’? > > [-Werror=implicit-function-declaration] > > 73 379 | fixed_phy_unregister(phydev); > > 74 | ^~~~~~~~~~~~~~~~~~~~ > > 75 | fixed_phy_register > > 76 ../drivers/of/of_mdio.c:381:22: error: ‘struct phy_device’ has no > > member named ‘mdio’; did you mean ‘mdix’? > > 77 381 | put_device(&phydev->mdio.dev); /* of_phy_find_device() */ > > 78 | ^~~~ > > 79 | mdix > > Another dependency: 5bcbe0f35fb1 ("phy: fixed: Fix removal of phys.") > > Greg, these patches are from four years ago so can't really remember if > there are other dependencies or reasons against backporting them (the > missing stable tags are per Dave's preference), sorry. > > The cover letter also mentions another dependency, but that may just > have been some context conflict. > > Perhaps you better drop these unless you want to review them closer. Good idea, I've dropped them all for now, sorry for the noise. greg k-h