From: "Daniel Walker (danielwa)" <danielwa@cisco.com>
To: Pratyush Yadav <me@yadavpratyush.com>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Richard Weinberger <richard@nod.at>,
"xe-linux-external(mailer list)" <xe-linux-external@cisco.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"Miquel Raynal" <miquel.raynal@bootlin.com>
Subject: Re: [RFC-PATCH] mtd: spi-nor: add conditional 4B opcodes
Date: Fri, 8 May 2020 19:28:27 +0000 [thread overview]
Message-ID: <20200508192827.GH9016@zorba> (raw)
In-Reply-To: <20200508190735.tpgeuirsnyjexfz4@yadavpratyush.com>
On Sat, May 09, 2020 at 12:37:35AM +0530, Pratyush Yadav wrote:
> Hi Daniel,
>
> On 07/05/20 06:13PM, Daniel Walker (danielwa) wrote:
> > On Thu, May 07, 2020 at 11:33:46PM +0530, Pratyush Yadav wrote:
> > > On 07/05/20 09:20AM, Daniel Walker wrote:
> > > > Some chips have 4B opcodes, but there is no way to know if they have
> > > > them. This device tree option allows platform owners to force enable 4b
> > > > opcodes when they know their chips support it even when it can be
> > > > automatically identified.
> > >
> > > Do you mean that two chips might have the same ID but one of them can
> > > support 4B opcodes and the other can not? Is it possible to detect this
> > > in a fixup hook? I think it would be better to do something like this in
> > > a fixup hook instead of via device tree.
> >
> > Yes. The chip I added the option for is an example of this, it's n25q256a. I'm not familiar with the
> > fixup hook mechanism, but I would assume you need some way to tell between the 4B
> > opcode chips and the non-4B opcode chips. For n25q256a, we have not found a way
> > to do that.
>
> I'm assuming this patch is related to [0]. If all you want is to address
> memory above 16M, why not switch to 4-byte addressing mode instead?
> Taking a quick look at the datasheet tells me this can be done via the
> "Enter 4-byte address mode" command (0xB7). Then just use the regular
> read/program commands with 4-byte addresses. Does that work for you? Is
> there any reason you _have_ to use dedicated 4B opcodes?
It might, I don't think we need anything beyond access to move than 16M. Your
proposal would be to have a hook which enters the 0xB7 command?
I guess the question would be do all the chips have this ability.
Daniel
next prev parent reply other threads:[~2020-05-08 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 16:20 [RFC-PATCH] mtd: spi-nor: add conditional 4B opcodes Daniel Walker
2020-05-07 18:03 ` Pratyush Yadav
2020-05-07 18:13 ` Daniel Walker (danielwa)
2020-05-08 19:07 ` Pratyush Yadav
2020-05-08 19:28 ` Daniel Walker (danielwa) [this message]
2020-05-10 10:43 ` Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508192827.GH9016@zorba \
--to=danielwa@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=me@yadavpratyush.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).