From: Luis Chamberlain <mcgrof@kernel.org>
To: Rafael Aquini <aquini@redhat.com>
Cc: Tso Ted <tytso@mit.edu>, Adrian Bunk <bunk@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Laura Abbott <labbott@redhat.com>, Jeff Mahoney <jeffm@suse.com>,
Jiri Kosina <jikos@kernel.org>, Jessica Yu <jeyu@suse.de>,
Takashi Iwai <tiwai@suse.de>, Ann Davis <AnDavis@suse.com>,
Richard Palethorpe <rpalethorpe@suse.de>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org,
dyoung@redhat.com, bhe@redhat.com, corbet@lwn.net,
keescook@chromium.org, akpm@linux-foundation.org, cai@lca.pw,
rdunlap@infradead.org
Subject: Re: [PATCH v2] kernel: add panic_on_taint
Date: Sat, 9 May 2020 03:48:54 +0000 [thread overview]
Message-ID: <20200509034854.GI11244@42.do-not-panic.com> (raw)
In-Reply-To: <20200508124719.GB367616@optiplex-lnx>
On Fri, May 08, 2020 at 08:47:19AM -0400, Rafael Aquini wrote:
> On Thu, May 07, 2020 at 10:25:58PM +0000, Luis Chamberlain wrote:
> > On Thu, May 07, 2020 at 06:06:06PM -0400, Rafael Aquini wrote:
> > > On Thu, May 07, 2020 at 08:33:40PM +0000, Luis Chamberlain wrote:
> > > > I *think* that a cmdline route to enable this would likely remove the
> > > > need for the kernel config for this. But even with Vlastimil's work
> > > > merged, I think we'd want yet-another value to enable / disable this
> > > > feature. Do we need yet-another-taint flag to tell us that this feature
> > > > was enabled?
> > > >
> > >
> > > I guess it makes sense to get rid of the sysctl interface for
> > > proc_on_taint, and only keep it as a cmdline option.
> >
> > That would be easier to support and k3eps this simple.
> >
> > > But the real issue seems to be, regardless we go with a cmdline-only option
> > > or not, the ability of proc_taint() to set any arbitrary taint flag
> > > other than just marking the kernel with TAINT_USER.
> >
> > I think we would have no other option but to add a new TAINT flag so
> > that we know that the taint flag was modified by a user. Perhaps just
> > re-using TAINT_USER when proc_taint() would suffice.
> >
>
> We might not need an extra taint flag if, perhaps, we could make these
> two features mutually exclusive. The idea here is that bitmasks added
> via panic_on_taint get filtered out in proc_taint(), so a malicious
> user couldn't exploit the latter interface to easily panic the system,
> when the first one is also in use.
I get it, however I I can still see the person who enables enabling
panic-on-tain wanting to know if proc_taint() was used. So even if
it was not on their mask, if it was modified that seems like important
information for a bug report analysis.
Luis
next prev parent reply other threads:[~2020-05-09 3:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 18:06 [PATCH v2] kernel: add panic_on_taint Rafael Aquini
2020-05-07 18:22 ` Luis Chamberlain
2020-05-07 18:43 ` Rafael Aquini
2020-05-07 18:47 ` Rafael Aquini
2020-05-07 20:33 ` Luis Chamberlain
2020-05-07 22:06 ` Rafael Aquini
2020-05-07 22:25 ` Luis Chamberlain
2020-05-08 12:47 ` Rafael Aquini
2020-05-09 3:48 ` Luis Chamberlain [this message]
2020-05-09 14:56 ` Rafael Aquini
2020-05-07 18:50 ` Luis Chamberlain
2020-05-07 18:53 ` Rafael Aquini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200509034854.GI11244@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=AnDavis@suse.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=bhe@redhat.com \
--cc=bunk@kernel.org \
--cc=cai@lca.pw \
--cc=corbet@lwn.net \
--cc=dyoung@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jeffm@suse.com \
--cc=jeyu@suse.de \
--cc=jikos@kernel.org \
--cc=keescook@chromium.org \
--cc=kexec@lists.infradead.org \
--cc=labbott@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rpalethorpe@suse.de \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).