From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23F70C28CBC for ; Sat, 9 May 2020 11:45:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA10521655 for ; Sat, 9 May 2020 11:45:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="dScxEOEP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728364AbgEILpi (ORCPT ); Sat, 9 May 2020 07:45:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726063AbgEILpi (ORCPT ); Sat, 9 May 2020 07:45:38 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85BB9C061A0C; Sat, 9 May 2020 04:45:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=KiW60T3hTB2qpy6736Bxcw2MHOpni1wIvO5W/zMNZ1U=; b=dScxEOEPFAX93tSikUpNlmorU Ud2kA2lUknBqfsPTkWQ2niqbdThBKyTUvRHH3rKqgp5Ikovwkw3E1j5LwaXgrODtJ1Q34TqSdZ3Lc DJuqL9okq9w+0UJ+gG49wEiY7SbY7URGE520Z3WoWT3zGowMr1bQqXeX25ddgdWGmRWeuO4GZIcmo tahxCA17P2BuoHENH/I0g5X9Ewa0e/vcpS25lTh7AE+nbBee1eNOLNGOrtA93dL19erh1olQjeALZ 8yG0PBo7SFlNS8hsROxrwr+tIRxsjNRl9qi5n94y8FuAvcAupkRKteByPPXw5GAK/bkoaFLlaBZID CmNhNf3dA==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:55720) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jXNv1-0003gT-TW; Sat, 09 May 2020 12:45:24 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jXNuw-0002pE-BR; Sat, 09 May 2020 12:45:18 +0100 Date: Sat, 9 May 2020 12:45:18 +0100 From: Russell King - ARM Linux admin To: Stefan Chulski , Matteo Croce Cc: "David S . Miller" , Maxime Chevallier , netdev , LKML , Antoine Tenart , Thomas Petazzoni , "gregory.clement@bootlin.com" , "miquel.raynal@bootlin.com" , Nadav Haklai , Marcin Wojtas , Linux ARM Subject: Re: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to handle RSS tables Message-ID: <20200509114518.GB1551@shell.armlinux.org.uk> References: <20190524100554.8606-1-maxime.chevallier@bootlin.com> <20190524100554.8606-4-maxime.chevallier@bootlin.com> <20200423170003.GT25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 09, 2020 at 11:15:58AM +0000, Stefan Chulski wrote: > > > > -----Original Message----- > > From: Matteo Croce > > Sent: Saturday, May 9, 2020 3:13 AM > > To: David S . Miller > > Cc: Maxime Chevallier ; netdev > > ; LKML ; Antoine > > Tenart ; Thomas Petazzoni > > ; gregory.clement@bootlin.com; > > miquel.raynal@bootlin.com; Nadav Haklai ; Stefan > > Chulski ; Marcin Wojtas ; Linux > > ARM ; Russell King - ARM Linux admin > > > > Subject: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to > > handle RSS tables > > > > Hi, > > > > What do you think about temporarily disabling it like this? > > > > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > @@ -5775,7 +5775,8 @@ static int mvpp2_port_probe(struct platform_device > > *pdev, > > NETIF_F_HW_VLAN_CTAG_FILTER; > > > > if (mvpp22_rss_is_supported()) { > > - dev->hw_features |= NETIF_F_RXHASH; > > + if (port->phy_interface != PHY_INTERFACE_MODE_SGMII) > > + dev->hw_features |= NETIF_F_RXHASH; > > dev->features |= NETIF_F_NTUPLE; > > } > > > > > > David, is this "workaround" too bad to get accepted? > > Not sure that RSS related to physical interface(SGMII), better just remove NETIF_F_RXHASH as "workaround". Hmm, I'm not sure this is the right way forward. This patch has the effect of disabling: d33ec4525007 ("net: mvpp2: add an RSS classification step for each flow") but the commit you're pointing at which caused the regression is: 895586d5dc32 ("net: mvpp2: cls: Use RSS contexts to handle RSS tables") Looking at the timeline here, it looks like Matteo raised the issue very quickly after the patch was sent on the 14th April, and despite following up on it, despite me following up on it, bootlin have remained quiet. For a regression, that's not particularly good, and doesn't leave many options but to ask davem to revert a commit, or if possible fix it (which there doesn't seem to be any willingness for either - maybe it's a feature no one uses on this platform?) Would reverting the commit you point to as the cause (895586d5dc32) resolve the problem, and have any advantage over entirely disabling RSS? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up