From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B7BEC28CBC for ; Sat, 9 May 2020 13:25:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6058020722 for ; Sat, 9 May 2020 13:25:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="CC1qQzYw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727834AbgEINZk (ORCPT ); Sat, 9 May 2020 09:25:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726013AbgEINZk (ORCPT ); Sat, 9 May 2020 09:25:40 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A0C6C061A0C; Sat, 9 May 2020 06:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xxlsFN8Q2F7QH7NHZLiYgcMIZjPCMsIK8HIfpq4aIt4=; b=CC1qQzYwUvi3gcWuWkniLvbVn +1SRe5Cwu1ktiXbITbx+OQsj8ufkHeYyYXavUQ5G5gwuX8rEDg/htQ5Z3UTaSlk1FaY3fbig7HjaG 4jngtXZSQnGJNq86asL7QOfbiLmUL4ynk0NVBKbW4DfmWiRrCwmjM83LRyssNFOg4ypmuT5CDjrBv p8Hzmc5aThtcAw2lvomwaQSPUA55cbUugMVtTVHNQT2EopMpJlHYOwfb99RjDxWfYUtnWSiC3iwfG X/VuA0b750K672ePelBIBzgBLRIMg+49G/ukh6HsSUZnSw8FcWZI4KjPwFRVaCNsxQL3SqKCMQW1G 7KVQRW2aA==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:38026) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jXPTr-0003zF-P5; Sat, 09 May 2020 14:25:29 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jXPTo-0002su-Mn; Sat, 09 May 2020 14:25:24 +0100 Date: Sat, 9 May 2020 14:25:24 +0100 From: Russell King - ARM Linux admin To: Stefan Chulski Cc: Matteo Croce , "David S . Miller" , Maxime Chevallier , netdev , LKML , Antoine Tenart , Thomas Petazzoni , "gregory.clement@bootlin.com" , "miquel.raynal@bootlin.com" , Nadav Haklai , Marcin Wojtas , Linux ARM Subject: Re: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to handle RSS tables Message-ID: <20200509132524.GD1551@shell.armlinux.org.uk> References: <20190524100554.8606-1-maxime.chevallier@bootlin.com> <20190524100554.8606-4-maxime.chevallier@bootlin.com> <20200423170003.GT25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 09, 2020 at 12:31:21PM +0000, Stefan Chulski wrote: > > -----Original Message----- > > From: Matteo Croce > > Sent: Saturday, May 9, 2020 3:16 PM > > To: Stefan Chulski > > Cc: David S . Miller ; Maxime Chevallier > > ; netdev ; LKML > > ; Antoine Tenart > > ; Thomas Petazzoni > > ; gregory.clement@bootlin.com; > > miquel.raynal@bootlin.com; Nadav Haklai ; Marcin > > Wojtas ; Linux ARM > kernel@lists.infradead.org>; Russell King - ARM Linux admin > > > > Subject: Re: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to > > handle RSS tables > > > > Hi, > > > > The point is that RXHASH works fine on all interfaces, but on the gigabit one > > (eth2 usually). > > And on the 10 gbit interface is very very effective, the throughput goes 4x when > > enabled, so it would be a big drawback to disable it on all interfaces. > > > > Honestly I don't have any 2.5 gbit hardware to test it on eth3, so I don't know if > > rxhash actually only works on the first interface of a unit (so eth0 and eth1), or > > if it just doesn't work on the gigabit one. > > > > If someone could test it on the 2.5 gbit port, this will be helpful. > > RSS tables is part of Packet Processor IP, not MAC(so it's not related to specific speed). Probably issue exist on specific packet processor ports. > Since RSS work fine on first port of the CP, we can do the following: > if (port-> id == 0) > dev->hw_features |= NETIF_F_RXHASH; I can confirm that Macchiatobin Single Shot eth0 port works with a 1G Fibre SFP or 10G DA SFP with or without rxhash on. So it seems Stefan's hunch that it is port related is correct. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up