From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38B78C54E4A for ; Sat, 9 May 2020 21:58:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14E8C21655 for ; Sat, 9 May 2020 21:58:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589061493; bh=8LDwYge0vi4f67R9PaFiUhi9lpFstDMiQuOLGmpth7k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=1mkBwYSO8Tl2orM70R2UULtHaf/FWiyjSm5kJGgsrh5epF0dahbNJITPn9BF4GvL7 b1fXfVt774UOlEw3gymoTiWN9bk9WVeH9wjm9b9NdDP5uuSodQwLIbAgQhcQqW5IMw Aeptdu0Hq3ekSND1ZbxbHlfbC9V6tcPk6vvT/srE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728718AbgEIV6L (ORCPT ); Sat, 9 May 2020 17:58:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:36336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728408AbgEIV6I (ORCPT ); Sat, 9 May 2020 17:58:08 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1159320A8B; Sat, 9 May 2020 21:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589061488; bh=8LDwYge0vi4f67R9PaFiUhi9lpFstDMiQuOLGmpth7k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=K2+i6h0Qfml79Q9GynUDuEHqxkFRC42Z/v4aibYZA8p+JTUZ+9dxA+4oAZ3Ec2477 MZMt2m2FmiLtUmRripbB0L640+1e5RedlLKQ+vSpGzloTIU0UHMsSMK15HJ4FJCopm 0uhWtMvUV6IWBjE4pzIntuYKps9WjI8r19kBahBA= Date: Sat, 9 May 2020 14:58:06 -0700 From: Jakub Kicinski To: Russell King - ARM Linux admin Cc: Matteo Croce , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Thomas Petazzoni , Stefan Chulski Subject: Re: [PATCH net] mvpp2: enable rxhash only on the first port Message-ID: <20200509145806.3e82a710@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200509202355.GL1551@shell.armlinux.org.uk> References: <20200509141546.5750-1-mcroce@redhat.com> <20200509202355.GL1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 9 May 2020 21:23:55 +0100 Russell King - ARM Linux admin wrote: > I seem to have discovered the cause of the problem in the old thread, > so I suggest we wait and see whether anyone offers up a proper > solution to this regression before we rush to completely disable > this feature. > > I would suggest with a high degress of confidence based on my > research that prior to the offending commit (895586d5dc32), rx > hashing was working fine, distributing interrupts across the cores. Ack, dropping this from patchwork for now. Thanks for the guidance.