linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com
Cc: Mark Brown <broonie@kernel.org>,
	sre@kernel.org, linux-pm@vger.kernel.org,
	brendanhiggins@google.com, linux-kernel@vger.kernel.org,
	lgirdwood@gmail.com
Subject: [PATCH] lib: linear_ranges: Add missing MODULE_LICENSE()
Date: Sat, 9 May 2020 18:15:19 +0300	[thread overview]
Message-ID: <20200509151519.GA7100@localhost.localdomain> (raw)

When linear_ranges is compiled as module we get warning
about missing MODULE_LICENSE(). Fix it by adding
MODULE_LICENSE("GPL") as is suggested by SPDX and EXPORTs.

Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
---

I saw Mark applied the linear-ranges patch. So I sent this fix as
incremental patch - but I still use the same Linus tree as a base of
this fix - the linear-ranges file should be unchanged in regulator tree.
If this does not apply I can clone regulator tree and create this fix on
it.

I don't know if this is the correct way to fix this as the linear-ranges
should be merged to power-supply tree.

I guess we can either:
- Use this patch to fix regulator tree and create fixed tag for
  power-supply(?)
- Add this fix in the original series and resend whole series(?)
- re-create the series and drop the already applied patches. Add this
  fix as a fixup patch in new series and apply it to power-supply tree
  after the linear-ranges from regulator is merged to power-supply.

 Please adviece me if this patch is not the way to go.

Oh, and I am really sorry for the trouble. I saw I had regulators=y
in all of my compilations due to some pincontrol dependencies. So
linear-ranges was not built as module in any of my test compilations :(

Thanks for testing Mark!

 lib/linear_ranges.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/linear_ranges.c b/lib/linear_ranges.c
index d1336c75ccd7..9495ef3572b7 100644
--- a/lib/linear_ranges.c
+++ b/lib/linear_ranges.c
@@ -12,6 +12,7 @@
 #include <linux/export.h>
 #include <linux/kernel.h>
 #include <linux/linear_range.h>
+#include <linux/module.h>
 
 /**
  * linear_range_values_in_range - return the amount of values in a range
@@ -239,3 +240,6 @@ int linear_range_get_selector_high(const struct linear_range *r,
 	return 0;
 }
 EXPORT_SYMBOL_GPL(linear_range_get_selector_high);
+
+MODULE_DESCRIPTION("linear-ranges helper");
+MODULE_LICENSE("GPL");
-- 
2.21.0


-- 
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =] 

             reply	other threads:[~2020-05-09 15:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09 15:15 Matti Vaittinen [this message]
2020-05-10 19:50 ` [PATCH] lib: linear_ranges: Add missing MODULE_LICENSE() Sebastian Reichel
2020-05-11  6:55   ` Vaittinen, Matti
2020-05-11 11:25 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200509151519.GA7100@localhost.localdomain \
    --to=matti.vaittinen@fi.rohmeurope.com \
    --cc=brendanhiggins@google.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).