* Re: [PATCH] iio: sca3000: Remove an erroneous get_device() call in sca3000_read_data()
@ 2020-05-06 15:30 Markus Elfring
2020-05-10 9:55 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-05-06 15:30 UTC (permalink / raw)
To: Christophe Jaillet, linux-iio
Cc: kernel-janitors, linux-kernel, Dan Carpenter, Greg Kroah-Hartman,
Hartmut Knaack, Jonathan Cameron, Lars-Peter Clausen,
Peter Meerwald-Stadler, Thomas Gleixner
> This looks really unusual to have a 'get_device()' hidden in a 'dev_err()' call.
Is there a need to prevent similar function calls by the means of
advanced source code analysis?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: sca3000: Remove an erroneous get_device() call in sca3000_read_data()
2020-05-06 15:30 [PATCH] iio: sca3000: Remove an erroneous get_device() call in sca3000_read_data() Markus Elfring
@ 2020-05-10 9:55 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2020-05-10 9:55 UTC (permalink / raw)
To: Markus Elfring
Cc: Christophe Jaillet, linux-iio, kernel-janitors, linux-kernel,
Dan Carpenter, Greg Kroah-Hartman, Hartmut Knaack,
Lars-Peter Clausen, Peter Meerwald-Stadler, Thomas Gleixner
On Wed, 6 May 2020 17:30:06 +0200
Markus Elfring <Markus.Elfring@web.de> wrote:
> > This looks really unusual to have a 'get_device()' hidden in a 'dev_err()' call.
>
> Is there a need to prevent similar function calls by the means of
> advanced source code analysis?
It's a seriously stupid bug so I'd have thought unlikely to
occur often enough to be worth it.
Jonathan
>
> Regards,
> Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-10 9:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06 15:30 [PATCH] iio: sca3000: Remove an erroneous get_device() call in sca3000_read_data() Markus Elfring
2020-05-10 9:55 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).