From: Chris Ruehl <chris.ruehl@gtsys.com.hk>
To: Chris Ruehl <chris.ruehl@gtsys.com.hk>, Jack Lo <jack.lo@gtsys.com.hk>
Cc: Mark Brown <broonie@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1 0/3] spi: spi-rockchip spi slave mode
Date: Mon, 11 May 2020 16:30:19 +0800 [thread overview]
Message-ID: <20200511083022.23678-1-chris.ruehl@gtsys.com.hk> (raw)
The spi-rockchip driver does not implement spi slave mode, but the register map
have a corresponding flag. An example implementation found
here: https://dev.t-firefly.com/thread-101485-1-1.html
This patchset clean the compatiblity names and add support slave mode.
We need the slave mode for our project, but the PCBA is not yet available
in consequence the code in the patch isn't tested yet but need your review.
Patch 1/3
Cleanup, move from the compatibily layer struct spi_master over
to struct spi_controller, and rename the related function calls.
Patch 2/3
Add support for spi slave mode and support function
Patch 3/3
Use OF property num-cs and enable support for cs_gpiods
IMHO its wrong, that the num_chipselect is set fixed to the amount of
native chip-select lines. SPI0 which has two native lines, while the others
SPIs one native cs line only.
Set max_native_cs in the controller struct with ROCKCHIP_SPI_MAX_CS_NUM seems
the correct way to do and let num-cs the OF / dts config set the CS count for
the boards.
Patch against next-20200508
Thanks for review!
Happy hacking
Chris
Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
---
next reply other threads:[~2020-05-11 8:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 8:30 Chris Ruehl [this message]
2020-05-11 8:30 ` [PATCH v1 1/3] spi: spi-rockchip: cleanup use struct spi_controller Chris Ruehl
2020-05-11 8:30 ` [PATCH v1 2/3] spi: spi-rockchip: add support for spi slave mode Chris Ruehl
2020-05-11 8:30 ` [PATCH v1 3/3] spi: spi-rockchip: use num-cs property and ctlr->enable_gpiods Chris Ruehl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511083022.23678-1-chris.ruehl@gtsys.com.hk \
--to=chris.ruehl@gtsys.com.hk \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=jack.lo@gtsys.com.hk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).