linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Gwendal Grignou <gwendal@chromium.org>,
	enric.balletbo@collabora.com, jic23@kernel.org
Cc: kbuild-all@lists.01.org, bleung@chromium.org,
	groeck@chromium.org, linux-kernel@vger.kernel.org,
	linux-iio@vger.kernel.org, Gwendal Grignou <gwendal@chromium.org>
Subject: Re: [PATCH v2 3/3] iio: cros_ec_light: Add support for RGB sensor
Date: Mon, 11 May 2020 10:34:40 +0800	[thread overview]
Message-ID: <202005111005.ISGTjXHg%lkp@intel.com> (raw)
In-Reply-To: <20200506230324.139241-4-gwendal@chromium.org>

[-- Attachment #1: Type: text/plain, Size: 5333 bytes --]

Hi Gwendal,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on iio/togreg]
[also build test ERROR on chrome-platform-linux/for-next linus/master v5.7-rc5 next-20200508]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Gwendal-Grignou/iio-cros_ec-Add-support-for-RGB-light-sensor/20200507-074251
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/iio/light/cros_ec_light_prox.c:39:40: warning: left-hand operand of comma expression has no effect [-Wunused-value]
    #define CROS_EC_LIGHT_RGB_SPACE_MASK (6, 4)
                                           ^
   drivers/iio/light/cros_ec_light_prox.c:51:2: note: in expansion of macro 'CROS_EC_LIGHT_RGB_SPACE_MASK'
     CROS_EC_LIGHT_RGB_SPACE_MASK,
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/iio/light/cros_ec_light_prox.c:39:38: error: initializer element is not constant
    #define CROS_EC_LIGHT_RGB_SPACE_MASK (6, 4)
                                         ^
   drivers/iio/light/cros_ec_light_prox.c:51:2: note: in expansion of macro 'CROS_EC_LIGHT_RGB_SPACE_MASK'
     CROS_EC_LIGHT_RGB_SPACE_MASK,
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/iio/light/cros_ec_light_prox.c:39:38: note: (near initialization for 'cros_ec_light_prox_bitmasks[3]')
    #define CROS_EC_LIGHT_RGB_SPACE_MASK (6, 4)
                                         ^
   drivers/iio/light/cros_ec_light_prox.c:51:2: note: in expansion of macro 'CROS_EC_LIGHT_RGB_SPACE_MASK'
     CROS_EC_LIGHT_RGB_SPACE_MASK,
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/iio/light/cros_ec_light_prox.c:39:40: warning: left-hand operand of comma expression has no effect [-Wunused-value]
    #define CROS_EC_LIGHT_RGB_SPACE_MASK (6, 4)
                                           ^
   drivers/iio/light/cros_ec_light_prox.c:52:2: note: in expansion of macro 'CROS_EC_LIGHT_RGB_SPACE_MASK'
     CROS_EC_LIGHT_RGB_SPACE_MASK | CROS_EC_LIGHT_CLEAR_OR_PROXIMITY_MASK,
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/iio/light/cros_ec_light_prox.c:39:38: error: initializer element is not constant
    #define CROS_EC_LIGHT_RGB_SPACE_MASK (6, 4)
                                         ^
   drivers/iio/light/cros_ec_light_prox.c:52:2: note: in expansion of macro 'CROS_EC_LIGHT_RGB_SPACE_MASK'
     CROS_EC_LIGHT_RGB_SPACE_MASK | CROS_EC_LIGHT_CLEAR_OR_PROXIMITY_MASK,
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/iio/light/cros_ec_light_prox.c:39:38: note: (near initialization for 'cros_ec_light_prox_bitmasks[4]')
    #define CROS_EC_LIGHT_RGB_SPACE_MASK (6, 4)
                                         ^
   drivers/iio/light/cros_ec_light_prox.c:52:2: note: in expansion of macro 'CROS_EC_LIGHT_RGB_SPACE_MASK'
     CROS_EC_LIGHT_RGB_SPACE_MASK | CROS_EC_LIGHT_CLEAR_OR_PROXIMITY_MASK,
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/iio/light/cros_ec_light_prox.c: In function 'cros_ec_light_capture':
   drivers/iio/light/cros_ec_light_prox.c:39:40: warning: left-hand operand of comma expression has no effect [-Wunused-value]
    #define CROS_EC_LIGHT_RGB_SPACE_MASK (6, 4)
                                           ^
   drivers/iio/light/cros_ec_light_prox.c:404:19: note: in expansion of macro 'CROS_EC_LIGHT_RGB_SPACE_MASK'
         (scan_mask & CROS_EC_LIGHT_RGB_SPACE_MASK)) {
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/iio/light/cros_ec_light_prox.c: In function 'cros_ec_light_prox_update_scan_mode':
   drivers/iio/light/cros_ec_light_prox.c:39:40: warning: left-hand operand of comma expression has no effect [-Wunused-value]
    #define CROS_EC_LIGHT_RGB_SPACE_MASK (6, 4)
                                           ^
   drivers/iio/light/cros_ec_light_prox.c:434:24: note: in expansion of macro 'CROS_EC_LIGHT_RGB_SPACE_MASK'
     else if (*scan_mask & CROS_EC_LIGHT_RGB_SPACE_MASK)
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +39 drivers/iio/light/cros_ec_light_prox.c

    23	
    24	/*
    25	 * We may present up to 7 channels:
    26	 *
    27	 * +-----+-----+-----+-----+-----+-----+-----+
    28	 * |Clear|  X  |  Y  |  Z  | RED |BLUE |GREEN|
    29	 * |Prox |     |     |     |     |     |     |
    30	 * +-----+-----+-----+-----+-----+-----+-----+
    31	 *
    32	 * Prox[imity] is presented by proximity sensors.
    33	 * The clear channel is supported by single and color light sensors.
    34	 * Color light sensor either reports color information in the RGB space or
    35	 * the CIE 1931 XYZ (XYZ) color space.
    36	 */
    37	#define CROS_EC_LIGHT_CLEAR_OR_PROXIMITY_MASK GENMASK(0, 0)
    38	#define CROS_EC_LIGHT_XYZ_SPACE_MASK GENMASK(3, 1)
  > 39	#define CROS_EC_LIGHT_RGB_SPACE_MASK (6, 4)
    40	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 72487 bytes --]

  parent reply	other threads:[~2020-05-11  2:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06 23:03 [PATCH v3 0/3] iio: cros_ec: Add support for RGB light sensor Gwendal Grignou
2020-05-06 23:03 ` [PATCH v2 1/3] iio: Add in_illumincance vectors in different color spaces Gwendal Grignou
2020-05-08 15:16   ` Jonathan Cameron
2020-05-12  4:10     ` Gwendal Grignou
2020-05-16 15:49       ` Jonathan Cameron
2020-05-06 23:03 ` [PATCH v2 2/3] iio: cros_ec: Allow enabling/disabling calibration mode Gwendal Grignou
2020-05-06 23:03 ` [PATCH v2 3/3] iio: cros_ec_light: Add support for RGB sensor Gwendal Grignou
2020-05-08 15:23   ` Jonathan Cameron
2020-05-11  2:34   ` kbuild test robot [this message]
2020-05-11  6:31   ` kbuild test robot
2020-05-08 14:56 ` [PATCH v3 0/3] iio: cros_ec: Add support for RGB light sensor Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202005111005.ISGTjXHg%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bleung@chromium.org \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=jic23@kernel.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).