From: Vladimir Oltean <olteanv@gmail.com>
To: andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@gmail.com
Cc: davem@davemloft.net, kuba@kernel.org, jiri@mellanox.com,
idosch@idosch.org, rmk+kernel@armlinux.org.uk,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 net-next 00/15] Traffic support for dsa_8021q in vlan_filtering=1 mode
Date: Mon, 11 May 2020 16:53:23 +0300 [thread overview]
Message-ID: <20200511135338.20263-1-olteanv@gmail.com> (raw)
From: Vladimir Oltean <vladimir.oltean@nxp.com>
This series is an attempt to support as much as possible in terms of
traffic I/O from the network stack with the only dsa_8021q user thus
far, sja1105.
The hardware doesn't support pushing a second VLAN tag to packets that
are already tagged, so our only option is to combine the dsa_8021q with
the user tag into a single tag and decode that on the CPU.
The assumption is that there is a type of use cases for which 7 VLANs
per port are more than sufficient, and that there's another type of use
cases where the full 4096 entries are barely enough. Those use cases are
very different from one another, so I prefer trying to give both the
best experience by creating this best_effort_vlan_filtering knob to
select the mode in which they want to operate in.
v1 was submitted here:
https://patchwork.ozlabs.org/project/netdev/cover/20200510164255.19322-1-olteanv@gmail.com/
Changes in v2:
Patch 01/15:
- Rename variable from vlan_bridge_vtu to configure_vlans_while_disabled.
Patch 03/15:
- Be much more thorough, and make sure that things like virtual links
and FDB operations still work properly.
Patch 05/15:
- Free the vlan lists on teardown.
- Simplify sja1105_classify_vlan: only look at priv->expect_dsa_8021q.
- Keep vid 1 in the list of dsa_8021q VLANs, to make sure that untagged
packets transmitted from the stack, like PTP, continue to work in
VLAN-unaware mode.
Patch 06/15:
- Adapt to vlan_bridge_vtu variable name change.
Patch 11/15:
- In sja1105_best_effort_vlan_filtering_set, get the vlan_filtering
value of each port instead of just one time for port 0. Normally this
shouldn't matter, but it avoids issues when port 0 is disabled in
device tree.
Patch 14/14:
- Only do anything in sja1105_build_subvlans and in
sja1105_build_crosschip_subvlans when operating in
SJA1105_VLAN_BEST_EFFORT state. This avoids installing VLAN retagging
rules in unaware mode, which would cost us a penalty in terms of
usable frame memory.
Russell King (1):
net: dsa: provide an option for drivers to always receive bridge VLANs
Vladimir Oltean (14):
net: dsa: tag_8021q: introduce a vid_is_dsa_8021q helper
net: dsa: sja1105: keep the VLAN awareness state in a driver variable
net: dsa: sja1105: deny alterations of dsa_8021q VLANs from the bridge
net: dsa: sja1105: save/restore VLANs using a delta commit method
net: dsa: sja1105: allow VLAN configuration from the bridge in all
states
net: dsa: sja1105: exit sja1105_vlan_filtering when called multiple
times
net: dsa: sja1105: prepare tagger for handling DSA tags and VLAN
simultaneously
net: dsa: tag_8021q: support up to 8 VLANs per port using sub-VLANs
net: dsa: tag_sja1105: implement sub-VLAN decoding
net: dsa: sja1105: add a new best_effort_vlan_filtering devlink
parameter
net: dsa: sja1105: add packing ops for the Retagging Table
net: dsa: sja1105: implement a common frame memory partitioning
function
net: dsa: sja1105: implement VLAN retagging for dsa_8021q sub-VLANs
docs: net: dsa: sja1105: document the best_effort_vlan_filtering
option
.../networking/devlink-params-sja1105.txt | 27 +
Documentation/networking/dsa/sja1105.rst | 211 ++-
drivers/net/dsa/sja1105/sja1105.h | 29 +
.../net/dsa/sja1105/sja1105_dynamic_config.c | 33 +
drivers/net/dsa/sja1105/sja1105_main.c | 1128 +++++++++++++++--
drivers/net/dsa/sja1105/sja1105_spi.c | 6 +
.../net/dsa/sja1105/sja1105_static_config.c | 62 +-
.../net/dsa/sja1105/sja1105_static_config.h | 16 +
drivers/net/dsa/sja1105/sja1105_vl.c | 44 +-
include/linux/dsa/8021q.h | 42 +-
include/linux/dsa/sja1105.h | 5 +
include/net/dsa.h | 7 +
net/dsa/slave.c | 12 +-
net/dsa/tag_8021q.c | 108 +-
net/dsa/tag_sja1105.c | 38 +-
15 files changed, 1508 insertions(+), 260 deletions(-)
create mode 100644 Documentation/networking/devlink-params-sja1105.txt
--
2.17.1
next reply other threads:[~2020-05-11 13:53 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 13:53 Vladimir Oltean [this message]
2020-05-11 13:53 ` [PATCH v2 net-next 01/15] net: dsa: provide an option for drivers to always receive bridge VLANs Vladimir Oltean
2020-05-11 22:58 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 02/15] net: dsa: tag_8021q: introduce a vid_is_dsa_8021q helper Vladimir Oltean
2020-05-11 22:59 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 03/15] net: dsa: sja1105: keep the VLAN awareness state in a driver variable Vladimir Oltean
2020-05-11 22:59 ` kbuild test robot
2020-05-11 23:57 ` Vladimir Oltean
2020-05-12 3:26 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 04/15] net: dsa: sja1105: deny alterations of dsa_8021q VLANs from the bridge Vladimir Oltean
2020-05-12 3:28 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 05/15] net: dsa: sja1105: save/restore VLANs using a delta commit method Vladimir Oltean
2020-05-12 3:31 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 06/15] net: dsa: sja1105: allow VLAN configuration from the bridge in all states Vladimir Oltean
2020-05-12 3:25 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 07/15] net: dsa: sja1105: exit sja1105_vlan_filtering when called multiple times Vladimir Oltean
2020-05-12 3:32 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 08/15] net: dsa: sja1105: prepare tagger for handling DSA tags and VLAN simultaneously Vladimir Oltean
2020-05-12 3:34 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 09/15] net: dsa: tag_8021q: support up to 8 VLANs per port using sub-VLANs Vladimir Oltean
2020-05-12 3:35 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 10/15] net: dsa: tag_sja1105: implement sub-VLAN decoding Vladimir Oltean
2020-05-12 3:36 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 11/15] net: dsa: sja1105: add a new best_effort_vlan_filtering devlink parameter Vladimir Oltean
2020-05-12 3:37 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 12/15] net: dsa: sja1105: add packing ops for the Retagging Table Vladimir Oltean
2020-05-12 3:38 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 13/15] net: dsa: sja1105: implement a common frame memory partitioning function Vladimir Oltean
2020-05-12 3:39 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 14/15] net: dsa: sja1105: implement VLAN retagging for dsa_8021q sub-VLANs Vladimir Oltean
2020-05-12 3:41 ` Florian Fainelli
2020-05-11 13:53 ` [PATCH v2 net-next 15/15] docs: net: dsa: sja1105: document the best_effort_vlan_filtering option Vladimir Oltean
2020-05-12 3:43 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511135338.20263-1-olteanv@gmail.com \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@idosch.org \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).