From: Qais Yousef <qais.yousef@arm.com>
To: Patrick Bellasi <patrick.bellasi@matbug.net>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Luis Chamberlain <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
Quentin Perret <qperret@google.com>,
Valentin Schneider <valentin.schneider@arm.com>,
Pavan Kondeti <pkondeti@codeaurora.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] Documentation/sysctl: Document uclamp sysctl knobs
Date: Mon, 11 May 2020 16:28:50 +0100 [thread overview]
Message-ID: <20200511152849.cg5a56ojhey55btr@e107158-lin.cambridge.arm.com> (raw)
In-Reply-To: <877dxik4ob.derkling@matbug.com>
Hi Patrick
On 05/11/20 15:00, Patrick Bellasi wrote:
[...]
> > I have this now
> >
> > """
> > 984 This knob will not escape the range constraint imposed by sched_util_clamp_min
> > 985 defined above.
> > 986
> > 987 For example if
> > 988
> > 989 sched_util_clamp_min_rt_default = 800
> > 990 sched_util_clamp_min = 600
> > 991
> > 992 Then the boost will be clamped to 600 because 800 is outside of the permissible
> > 993 range of [0:600]. This could happen for instance if a powersave mode will
> > 994 restrict all boosts temporarily by modifying sched_util_clamp_min. As soon as
> > 995 this restriction is lifted, the requested sched_util_clamp_min_rt_default
> > 996 will take effect.
> > 997
> > 998 Any modification is applied lazily to currently running tasks and should be
> > 999 visible by the next wakeup.
> > """
>
> That's better IMHO, would just slightly change the last sentence to:
>
> Any modification is applied lazily to tasks and is effective
> starting from their next wakeup.
+1, will post v5 later today.
Thanks
--
Qais Yousef
next prev parent reply other threads:[~2020-05-11 15:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 11:49 [PATCH v4 1/2] sched/uclamp: Add a new sysctl to control RT default boost value Qais Yousef
2020-05-01 11:49 ` [PATCH v4 2/2] Documentation/sysctl: Document uclamp sysctl knobs Qais Yousef
2020-05-03 17:45 ` Patrick Bellasi
2020-05-05 14:56 ` Qais Yousef
2020-05-11 13:00 ` Patrick Bellasi
2020-05-11 15:28 ` Qais Yousef [this message]
2020-05-03 17:37 ` [PATCH v4 1/2] sched/uclamp: Add a new sysctl to control RT default boost value Patrick Bellasi
2020-05-05 14:27 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511152849.cg5a56ojhey55btr@e107158-lin.cambridge.arm.com \
--to=qais.yousef@arm.com \
--cc=bsegall@google.com \
--cc=corbet@lwn.net \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@matbug.net \
--cc=peterz@infradead.org \
--cc=pkondeti@codeaurora.org \
--cc=qperret@google.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).