From: Mark Brown <broonie@kernel.org>
To: Yongbo Zhang <giraffesnn123@gmail.com>
Cc: lgirdwood@gmail.com, Chen Li <licheng0822@thundersoft.com>,
alsa-devel@alsa-project.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v1] ASoC: rsnd: add interrupt support for SSI BUSIF buffer
Date: Mon, 11 May 2020 17:07:31 +0100 [thread overview]
Message-ID: <20200511160731.GA3618@sirena.org.uk> (raw)
In-Reply-To: <20200511100415.12502-1-giraffesnn123@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
On Mon, May 11, 2020 at 06:04:15PM +0800, Yongbo Zhang wrote:
> SSI BUSIF buffer is possible to overflow or underflow, especially in a
> hypervisor environment. If there is no interrupt support, it will eventually
> lead to errors in pcm data.
> This patch adds overflow and underflow interrupt support for SSI BUSIF buffer.
This introduces loads of build errors on for-5.8 with an x86
allmodconfig:
/mnt/kernel/sound/soc/sh/rcar/ssi.c: In function 'rsnd_ssi_quit':
/mnt/kernel/sound/soc/sh/rcar/ssi.c:596:12: error: invalid storage class for function 'rsnd_ssi_hw_params'
static int rsnd_ssi_hw_params(struct rsnd_mod *mod,
^~~~~~~~~~~~~~~~~~
/mnt/kernel/sound/soc/sh/rcar/ssi.c:596:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
static int rsnd_ssi_hw_params(struct rsnd_mod *mod,
^~~~~~
and so on for ages. Probably just needs a rebase I guess?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-05-11 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 10:04 [PATCH v1] ASoC: rsnd: add interrupt support for SSI BUSIF buffer Yongbo Zhang
2020-05-11 16:07 ` Mark Brown [this message]
2020-05-12 9:30 ` [PATCH v2] SoC: " Yongbo Zhang
2020-05-12 9:40 ` Mark Brown
2020-05-12 10:28 ` Mark Brown
2020-05-11 17:21 ` [PATCH v1] ASoC: " Mark Brown
2020-05-11 17:33 ` Mark Brown
2020-05-14 5:16 ` kbuild test robot
-- strict thread matches above, loose matches on Subject: below --
2020-05-11 9:45 Yongbo Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511160731.GA3618@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=giraffesnn123@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=licheng0822@thundersoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).