linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: timer: Document allwinner,erratum-unknown1 property
@ 2020-04-26 16:20 Samuel Holland
  2020-05-11 22:28 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Samuel Holland @ 2020-04-26 16:20 UTC (permalink / raw)
  To: Daniel Lezcano, Thomas Gleixner, Rob Herring
  Cc: linux-kernel, devicetree, Samuel Holland

This arch_timer property was added in commit c950ca8c35ee
("clocksource/drivers/arch_timer: Workaround for Allwinner A64 timer instability")
but I omitted the device tree binding documentation. Now
`make dtbs_check` prints the following warning for all A64 boards:

timer: 'allwinner,erratum-unknown1' does not match any of the regexes: 'pinctrl-[0-9]+'

Resolve this by documenting the erratum property.

Signed-off-by: Samuel Holland <samuel@sholland.org>
---
 Documentation/devicetree/bindings/timer/arm,arch_timer.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml
index fa255672e8e5..cf520c7e9094 100644
--- a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml
+++ b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml
@@ -51,6 +51,12 @@ properties:
     description: If present, the timer is powered through an always-on power
       domain, therefore it never loses context.
 
+  allwinner,erratum-unknown1:
+    type: boolean
+    description: Indicates the presence of an erratum found in Allwinner SoCs,
+      where reading certain values from the counter is unreliable. This also
+      affects writes to the tval register, due to the implicit counter read.
+
   fsl,erratum-a008585:
     type: boolean
     description: Indicates the presence of QorIQ erratum A-008585, which says
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: timer: Document allwinner,erratum-unknown1 property
  2020-04-26 16:20 [PATCH] dt-bindings: timer: Document allwinner,erratum-unknown1 property Samuel Holland
@ 2020-05-11 22:28 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2020-05-11 22:28 UTC (permalink / raw)
  To: Samuel Holland
  Cc: linux-kernel, Thomas Gleixner, Daniel Lezcano, Rob Herring, devicetree

On Sun, 26 Apr 2020 11:20:32 -0500, Samuel Holland wrote:
> This arch_timer property was added in commit c950ca8c35ee
> ("clocksource/drivers/arch_timer: Workaround for Allwinner A64 timer instability")
> but I omitted the device tree binding documentation. Now
> `make dtbs_check` prints the following warning for all A64 boards:
> 
> timer: 'allwinner,erratum-unknown1' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Resolve this by documenting the erratum property.
> 
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>  Documentation/devicetree/bindings/timer/arm,arch_timer.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Applied, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-11 22:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-26 16:20 [PATCH] dt-bindings: timer: Document allwinner,erratum-unknown1 property Samuel Holland
2020-05-11 22:28 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).