From: Kees Cook <keescook@chromium.org>
To: WeiXiong Liao <liaoweixiong@allwinnertech.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: offset align to block size bofore block operation
Date: Tue, 12 May 2020 09:33:03 -0700 [thread overview]
Message-ID: <202005120932.96313EB605@keescook> (raw)
In-Reply-To: <1589266715-4168-1-git-send-email-liaoweixiong@allwinnertech.com>
On Tue, May 12, 2020 at 02:58:35PM +0800, WeiXiong Liao wrote:
> The off parameter on mtdpsore_block_*() does not align to block size,
> which makes some bugs. For example, a block contains dmesg zones
> with number 0 to 3. When user remove all these files, mapped to
> these zones, mtdpstore is expected to check whether No.0 to No.3 is
> unused then erase this block. However it check No.3 to No.6 because
> it get wrongly beginning zonenum from misaligned off.
>
> Signed-off-by: WeiXiong Liao <liaoweixiong@allwinnertech.com>
Thanks! I've squashed this and will send a v8 of the mtdpstore
separately.
-Kees
--
Kees Cook
prev parent reply other threads:[~2020-05-12 16:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 6:58 [PATCH] mtd: offset align to block size bofore block operation WeiXiong Liao
2020-05-12 16:33 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202005120932.96313EB605@keescook \
--to=keescook@chromium.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=liaoweixiong@allwinnertech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tony.luck@intel.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).