* [PATCH] irqchip/sifive-plic: Remove incorrect requirement about number of irq contexts
@ 2020-05-12 17:26 Atish Patra
2020-05-13 21:34 ` Palmer Dabbelt
2020-05-30 7:46 ` [tip: irq/core] " tip-bot2 for Wesley W. Terpstra
0 siblings, 2 replies; 3+ messages in thread
From: Atish Patra @ 2020-05-12 17:26 UTC (permalink / raw)
To: linux-kernel
Cc: Wesley W. Terpstra, Atish Patra, Jason Cooper, linux-riscv,
Marc Zyngier, Palmer Dabbelt, Paul Walmsley, Thomas Gleixner
From: "Wesley W. Terpstra" <wesley@sifive.com>
A PLIC may not be connected to all the cores. In that case, nr_contexts
may be less than num_possible_cpus. This requirement is only valid a single
PLIC is the only interrupt controller for the whole system.
Signed-off-by: Atish Patra <atish.patra@wdc.com>
[Atish: Modified the commit text]
Signed-off-by: "Wesley W. Terpstra" <wesley@sifive.com>
---
drivers/irqchip/irq-sifive-plic.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
index d0a71febdadc..822e074c0600 100644
--- a/drivers/irqchip/irq-sifive-plic.c
+++ b/drivers/irqchip/irq-sifive-plic.c
@@ -301,8 +301,6 @@ static int __init plic_init(struct device_node *node,
nr_contexts = of_irq_count(node);
if (WARN_ON(!nr_contexts))
goto out_iounmap;
- if (WARN_ON(nr_contexts < num_possible_cpus()))
- goto out_iounmap;
error = -ENOMEM;
priv->irqdomain = irq_domain_add_linear(node, nr_irqs + 1,
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] irqchip/sifive-plic: Remove incorrect requirement about number of irq contexts
2020-05-12 17:26 [PATCH] irqchip/sifive-plic: Remove incorrect requirement about number of irq contexts Atish Patra
@ 2020-05-13 21:34 ` Palmer Dabbelt
2020-05-30 7:46 ` [tip: irq/core] " tip-bot2 for Wesley W. Terpstra
1 sibling, 0 replies; 3+ messages in thread
From: Palmer Dabbelt @ 2020-05-13 21:34 UTC (permalink / raw)
To: Atish Patra, Mark Zyngier, tglx
Cc: linux-kernel, wesley, Atish Patra, jason, linux-riscv, Paul Walmsley
On Tue, 12 May 2020 10:26:36 PDT (-0700), Atish Patra wrote:
> From: "Wesley W. Terpstra" <wesley@sifive.com>
>
> A PLIC may not be connected to all the cores. In that case, nr_contexts
> may be less than num_possible_cpus. This requirement is only valid a single
> PLIC is the only interrupt controller for the whole system.
>
> Signed-off-by: Atish Patra <atish.patra@wdc.com>
> [Atish: Modified the commit text]
> Signed-off-by: "Wesley W. Terpstra" <wesley@sifive.com>
> ---
> drivers/irqchip/irq-sifive-plic.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
> index d0a71febdadc..822e074c0600 100644
> --- a/drivers/irqchip/irq-sifive-plic.c
> +++ b/drivers/irqchip/irq-sifive-plic.c
> @@ -301,8 +301,6 @@ static int __init plic_init(struct device_node *node,
> nr_contexts = of_irq_count(node);
> if (WARN_ON(!nr_contexts))
> goto out_iounmap;
> - if (WARN_ON(nr_contexts < num_possible_cpus()))
> - goto out_iounmap;
>
> error = -ENOMEM;
> priv->irqdomain = irq_domain_add_linear(node, nr_irqs + 1,
Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>
Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>
I'm assuming this is going through the irqchip tree.
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip: irq/core] irqchip/sifive-plic: Remove incorrect requirement about number of irq contexts
2020-05-12 17:26 [PATCH] irqchip/sifive-plic: Remove incorrect requirement about number of irq contexts Atish Patra
2020-05-13 21:34 ` Palmer Dabbelt
@ 2020-05-30 7:46 ` tip-bot2 for Wesley W. Terpstra
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Wesley W. Terpstra @ 2020-05-30 7:46 UTC (permalink / raw)
To: linux-tip-commits
Cc: Atish Patra, Wesley W. Terpstra, Marc Zyngier, Palmer Dabbelt, x86, LKML
The following commit has been merged into the irq/core branch of tip:
Commit-ID: 82f2202ddc97490994fad0dbfec04a014fa5163d
Gitweb: https://git.kernel.org/tip/82f2202ddc97490994fad0dbfec04a014fa5163d
Author: Wesley W. Terpstra <wesley@sifive.com>
AuthorDate: Tue, 12 May 2020 10:26:36 -07:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Mon, 18 May 2020 10:28:30 +01:00
irqchip/sifive-plic: Remove incorrect requirement about number of irq contexts
A PLIC may not be connected to all the cores. In that case, nr_contexts
may be less than num_possible_cpus. This requirement is only valid a single
PLIC is the only interrupt controller for the whole system.
Signed-off-by: Atish Patra <atish.patra@wdc.com>
Signed-off-by: "Wesley W. Terpstra" <wesley@sifive.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>
Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>
Link: https://lore.kernel.org/r/20200512172636.96299-1-atish.patra@wdc.com
[Atish: Modified the commit text]
---
drivers/irqchip/irq-sifive-plic.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
index d0a71fe..822e074 100644
--- a/drivers/irqchip/irq-sifive-plic.c
+++ b/drivers/irqchip/irq-sifive-plic.c
@@ -301,8 +301,6 @@ static int __init plic_init(struct device_node *node,
nr_contexts = of_irq_count(node);
if (WARN_ON(!nr_contexts))
goto out_iounmap;
- if (WARN_ON(nr_contexts < num_possible_cpus()))
- goto out_iounmap;
error = -ENOMEM;
priv->irqdomain = irq_domain_add_linear(node, nr_irqs + 1,
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-30 7:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 17:26 [PATCH] irqchip/sifive-plic: Remove incorrect requirement about number of irq contexts Atish Patra
2020-05-13 21:34 ` Palmer Dabbelt
2020-05-30 7:46 ` [tip: irq/core] " tip-bot2 for Wesley W. Terpstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).