From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3B06C2D0F9 for ; Tue, 12 May 2020 20:34:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 822A120740 for ; Tue, 12 May 2020 20:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731115AbgELUef (ORCPT ); Tue, 12 May 2020 16:34:35 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:54948 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725950AbgELUee (ORCPT ); Tue, 12 May 2020 16:34:34 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 9E5288030807; Tue, 12 May 2020 20:34:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Fc4IUkLdqnm6; Tue, 12 May 2020 23:34:31 +0300 (MSK) Date: Tue, 12 May 2020 23:34:30 +0300 From: Serge Semin To: Andy Shevchenko CC: Serge Semin , Mark Brown , Georgy Vlasov , Ramil Zaripov , Alexey Malahov , Maxim Kaurkin , Pavel Parkhomenko , Ekaterina Skachko , Vadim Vlasov , Alexey Kolotnikov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Arnd Bergmann , Allison Randal , Gareth Williams , Rob Herring , , , , Subject: Re: [PATCH 00/17] spi: dw: Add generic DW DMA controller support Message-ID: <20200512203430.mohmki5nrmayzppr@mobilestation> References: <20200508132943.9826-1-Sergey.Semin@baikalelectronics.ru> <20200508173609.GQ4820@sirena.org.uk> <20200508191617.GR185537@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200508191617.GR185537@smile.fi.intel.com> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 08, 2020 at 10:16:17PM +0300, Andy Shevchenko wrote: > On Fri, May 08, 2020 at 06:36:09PM +0100, Mark Brown wrote: > > On Fri, May 08, 2020 at 04:29:25PM +0300, Serge Semin wrote: > > > Baikal-T1 SoC provides DW DMA controller to perform low-speed peripherals > > > Mem-to-Dev and Dev-to-Mem transaction. This is also applicable to the DW > > > APB SSI devices embedded into the SoC. Currently this type DMA device is > > > > This basically all looks good to me (without any hardware specific > > knowledge), I had a few comments but they were mostly procedural ones - > > mainly getting these bug fixes you've done merged as such. Nice work. > > Agree that is nice work! > Though, can you please give us chance to review next version of the series and test on our hardware? > > Serge, I think you should base it on spi/for-next rather than vanilla. Yeah, seeing there are potentially merge-conflict changes in the for-next branch I have to do the rebase. Will be done in v2. -Sergey > > -- > With Best Regards, > Andy Shevchenko > >