From: Luis Chamberlain <mcgrof@kernel.org>
To: Rafael Aquini <aquini@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
keescook@chromium.org, akpm@linux-foundation.org,
yzaikin@google.com, tytso@mit.edu
Subject: Re: [PATCH] kernel: sysctl: ignore out-of-range taint bits introduced via kernel.tainted
Date: Tue, 12 May 2020 22:31:10 +0000 [thread overview]
Message-ID: <20200512223110.GF11244@42.do-not-panic.com> (raw)
In-Reply-To: <20200512174653.770506-1-aquini@redhat.com>
On Tue, May 12, 2020 at 01:46:53PM -0400, Rafael Aquini wrote:
> The sysctl knob allows users with SYS_ADMIN capability to
> taint the kernel with any arbitrary value, but this might
> produce an invalid flags bitset being committed to tainted_mask.
>
> This patch introduces a simple way for proc_taint() to ignore
> any eventual invalid bit coming from the user input before
> committing those bits to the kernel tainted_mask.
>
> Signed-off-by: Rafael Aquini <aquini@redhat.com>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Luis
prev parent reply other threads:[~2020-05-12 22:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 17:46 [PATCH] kernel: sysctl: ignore out-of-range taint bits introduced via kernel.tainted Rafael Aquini
2020-05-12 20:53 ` Andrew Morton
2020-05-12 21:13 ` Rafael Aquini
2020-05-12 22:31 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512223110.GF11244@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).