* linux-next: build failure after merge of the fsinfo tree
@ 2020-05-12 9:57 Stephen Rothwell
2020-05-12 14:00 ` Masahiro Yamada
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Stephen Rothwell @ 2020-05-12 9:57 UTC (permalink / raw)
To: David Howells
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Masahiro Yamada
[-- Attachment #1: Type: text/plain, Size: 1317 bytes --]
Hi all,
After merging the fsinfo tree, today's linux-next build (x86_64
allmodconfig) failed like this:
/usr/lib/gcc-cross/x86_64-linux-gnu/9/../../../../x86_64-linux-gnu/bin/ld: cannot find /usr/lib/x86_64-linux-gnu/libm-2.30.a
/usr/lib/gcc-cross/x86_64-linux-gnu/9/../../../../x86_64-linux-gnu/bin/ld: cannot find /usr/lib/x86_64-linux-gnu/libmvec.a
I don't know if this is a quirk of the build system or Debian's cross
compiler setup. Both those files exist in /usr/x86_64-linux-gnu/lib/.
Masahiro, any thoughts?
I have disabled the building of test_fsinfo for now:
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 12 May 2020 19:49:33 +1000
Subject: [PATCH] disable building fo test-fsinfo for now
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
samples/vfs/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/samples/vfs/Makefile b/samples/vfs/Makefile
index f5bc5dfdf045..97e54c8be358 100644
--- a/samples/vfs/Makefile
+++ b/samples/vfs/Makefile
@@ -1,5 +1,5 @@
# SPDX-License-Identifier: GPL-2.0-only
-userprogs := test-fsinfo test-fsmount test-mntinfo test-statx
+userprogs := test-fsmount test-mntinfo test-statx
always-y := $(userprogs)
userccflags += -I usr/include
--
2.26.2
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge of the fsinfo tree
2020-05-12 9:57 linux-next: build failure after merge of the fsinfo tree Stephen Rothwell
@ 2020-05-12 14:00 ` Masahiro Yamada
2020-05-12 14:14 ` Stephen Rothwell
2020-05-12 23:18 ` David Howells
2020-05-12 23:26 ` David Howells
2 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2020-05-12 14:00 UTC (permalink / raw)
To: Stephen Rothwell
Cc: David Howells, Linux Next Mailing List, Linux Kernel Mailing List
On Tue, May 12, 2020 at 6:57 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the fsinfo tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> /usr/lib/gcc-cross/x86_64-linux-gnu/9/../../../../x86_64-linux-gnu/bin/ld: cannot find /usr/lib/x86_64-linux-gnu/libm-2.30.a
> /usr/lib/gcc-cross/x86_64-linux-gnu/9/../../../../x86_64-linux-gnu/bin/ld: cannot find /usr/lib/x86_64-linux-gnu/libmvec.a
>
> I don't know if this is a quirk of the build system or Debian's cross
> compiler setup. Both those files exist in /usr/x86_64-linux-gnu/lib/.
>
> Masahiro, any thoughts?
>
> I have disabled the building of test_fsinfo for now:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 12 May 2020 19:49:33 +1000
> Subject: [PATCH] disable building fo test-fsinfo for now
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> samples/vfs/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/vfs/Makefile b/samples/vfs/Makefile
> index f5bc5dfdf045..97e54c8be358 100644
> --- a/samples/vfs/Makefile
> +++ b/samples/vfs/Makefile
> @@ -1,5 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0-only
> -userprogs := test-fsinfo test-fsmount test-mntinfo test-statx
> +userprogs := test-fsmount test-mntinfo test-statx
> always-y := $(userprogs)
>
> userccflags += -I usr/include
> --
> 2.26.2
>
> --
> Cheers,
> Stephen Rothwell
I also failed to build it, but the error message
was different.
The following worked for me at least.
(Ubuntu 20.04).
diff --git a/samples/vfs/Makefile b/samples/vfs/Makefile
index 97e54c8be358..539fb3a56af3 100644
--- a/samples/vfs/Makefile
+++ b/samples/vfs/Makefile
@@ -1,7 +1,8 @@
# SPDX-License-Identifier: GPL-2.0-only
-userprogs := test-fsmount test-mntinfo test-statx
+userprogs := test-fsinfo test-fsmount test-mntinfo test-statx
always-y := $(userprogs)
userccflags += -I usr/include
-test-fsinfo-userldflags += -static -lm
+test-fsinfo-userldflags := -static
+test-fsinfo-userldlibs := -lm
David,
BTW, why is '-static' needed here?
--
Best Regards
Masahiro Yamada
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge of the fsinfo tree
2020-05-12 14:00 ` Masahiro Yamada
@ 2020-05-12 14:14 ` Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2020-05-12 14:14 UTC (permalink / raw)
To: Masahiro Yamada
Cc: David Howells, Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
Hi Masahiro,
On Tue, 12 May 2020 23:00:13 +0900 Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> I also failed to build it, but the error message
> was different.
>
> The following worked for me at least.
> (Ubuntu 20.04).
>
> diff --git a/samples/vfs/Makefile b/samples/vfs/Makefile
> index 97e54c8be358..539fb3a56af3 100644
> --- a/samples/vfs/Makefile
> +++ b/samples/vfs/Makefile
> @@ -1,7 +1,8 @@
> # SPDX-License-Identifier: GPL-2.0-only
> -userprogs := test-fsmount test-mntinfo test-statx
> +userprogs := test-fsinfo test-fsmount test-mntinfo test-statx
> always-y := $(userprogs)
>
> userccflags += -I usr/include
>
> -test-fsinfo-userldflags += -static -lm
> +test-fsinfo-userldflags := -static
> +test-fsinfo-userldlibs := -lm
Thanks, I will change the merge resolution to that.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge of the fsinfo tree
2020-05-12 9:57 linux-next: build failure after merge of the fsinfo tree Stephen Rothwell
2020-05-12 14:00 ` Masahiro Yamada
@ 2020-05-12 23:18 ` David Howells
2020-05-12 23:26 ` David Howells
2 siblings, 0 replies; 6+ messages in thread
From: David Howells @ 2020-05-12 23:18 UTC (permalink / raw)
To: Stephen Rothwell
Cc: dhowells, Linux Next Mailing List, Linux Kernel Mailing List,
Masahiro Yamada
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> /usr/lib/gcc-cross/x86_64-linux-gnu/9/../../../../x86_64-linux-gnu/bin/ld: cannot find /usr/lib/x86_64-linux-gnu/libm-2.30.a
> /usr/lib/gcc-cross/x86_64-linux-gnu/9/../../../../x86_64-linux-gnu/bin/ld: cannot find /usr/lib/x86_64-linux-gnu/libmvec.a
I'll remove my use of the pow() function to calculate the timestamp
granularities and just print the raw mantissa and exponent. That way I don't
need -lm at all.
David
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge of the fsinfo tree
2020-05-12 9:57 linux-next: build failure after merge of the fsinfo tree Stephen Rothwell
2020-05-12 14:00 ` Masahiro Yamada
2020-05-12 23:18 ` David Howells
@ 2020-05-12 23:26 ` David Howells
2 siblings, 0 replies; 6+ messages in thread
From: David Howells @ 2020-05-12 23:26 UTC (permalink / raw)
To: Masahiro Yamada
Cc: dhowells, Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List
Masahiro Yamada <masahiroy@kernel.org> wrote:
> BTW, why is '-static' needed here?
Sorry, that was a leftover. I've been building it on one version of Fedora
and running it on my test machine - which is a couple of versions behind. I
really need to do an update. Anyway, I've removed it and -lm.
David
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: build failure after merge of the fsinfo tree
@ 2020-05-12 10:47 Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2020-05-12 10:47 UTC (permalink / raw)
To: David Howells; +Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 2324 bytes --]
Hi all,
After merging the fsinfo tree, today's linux-next build (powerpc
allyesconfig) failed like this:
In file included from fs/fsinfo.c:7:
include/linux/syscalls.h:240:18: error: conflicting types for 'sys_fsinfo'
240 | asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \
| ^~~
include/linux/syscalls.h:226:2: note: in expansion of macro '__SYSCALL_DEFINEx'
226 | __SYSCALL_DEFINEx(x, sname, __VA_ARGS__)
| ^~~~~~~~~~~~~~~~~
include/linux/syscalls.h:220:36: note: in expansion of macro 'SYSCALL_DEFINEx'
220 | #define SYSCALL_DEFINE6(name, ...) SYSCALL_DEFINEx(6, _##name, __VA_ARGS__)
| ^~~~~~~~~~~~~~~
fs/fsinfo.c:655:1: note: in expansion of macro 'SYSCALL_DEFINE6'
655 | SYSCALL_DEFINE6(fsinfo,
| ^~~~~~~~~~~~~~~
In file included from fs/fsinfo.c:7:
include/linux/syscalls.h:1011:17: note: previous declaration of 'sys_fsinfo' was here
1011 | asmlinkage long sys_fsinfo(int dfd, const char __user *pathname,
| ^~~~~~~~~~
Caused by commit
51d01aee410b ("fsinfo: Add fsinfo() syscall to query filesystem information")
I have added the following patch for today.
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 12 May 2020 20:31:22 +1000
Subject: [PATCH] fix up sys_fsinfo decalaration
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
include/linux/syscalls.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
index 76064c0807e5..fa1ecee891c9 100644
--- a/include/linux/syscalls.h
+++ b/include/linux/syscalls.h
@@ -1009,8 +1009,9 @@ asmlinkage long sys_watch_mount(int dfd, const char __user *path,
asmlinkage long sys_watch_sb(int dfd, const char __user *path,
unsigned int at_flags, int watch_fd, int watch_id);
asmlinkage long sys_fsinfo(int dfd, const char __user *pathname,
- struct fsinfo_params __user *params, size_t params_size,
- void __user *result_buffer, size_t result_buf_size);
+ const struct fsinfo_params __user *params,
+ size_t params_size, void __user *result_buffer,
+ size_t result_buf_size);
/*
* Architecture-specific system calls
--
2.26.2
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-12 23:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 9:57 linux-next: build failure after merge of the fsinfo tree Stephen Rothwell
2020-05-12 14:00 ` Masahiro Yamada
2020-05-12 14:14 ` Stephen Rothwell
2020-05-12 23:18 ` David Howells
2020-05-12 23:26 ` David Howells
2020-05-12 10:47 Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).