Re: [PATCH v2 4/6] bus: mhi: core: Introduce debugfs entries and counters for MHI

From: kbuild test robot <lkp@intel.com>
To: Bhaumik Bhatt <bbhatt@codeaurora.org>, manivannan.sadhasivam@linaro.org
Cc: kbuild-all@lists.01.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, hemantk@codeaurora.org,
	jhugo@codeaurora.org, Bhaumik Bhatt <bbhatt@codeaurora.org>
Subject: Re: [PATCH v2 4/6] bus: mhi: core: Introduce debugfs entries and counters for MHI
Date: Wed, 13 May 2020 02:51:58 +0800	[thread overview]
Message-ID: <202005130221.EiJuYK8p%lkp@intel.com> (raw)
In-Reply-To: <1589305334-19466-5-git-send-email-bbhatt@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 2783 bytes --]

Hi Bhaumik,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20200512]
[cannot apply to linus/master v5.7-rc5 v5.7-rc4 v5.7-rc3 v5.7-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Bhaumik-Bhatt/Introduce-features-and-debugfs-sysfs-entries-for-MHI/20200513-014548
base:    e098d7762d602be640c53565ceca342f81e55ad2
config: um-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=um 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/bus/mhi/core/debugfs.c: In function 'mhi_debugfs_trigger_reset':
>> drivers/bus/mhi/core/debugfs.c:294:2: error: implicit declaration of function 'mhi_pm_sys_err_handler'; did you mean 'mhi_pm_sys_err_worker'? [-Werror=implicit-function-declaration]
mhi_pm_sys_err_handler(mhi_cntrl);
^~~~~~~~~~~~~~~~~~~~~~
mhi_pm_sys_err_worker
cc1: some warnings being treated as errors

vim +294 drivers/bus/mhi/core/debugfs.c

   259	
   260	static int mhi_debugfs_trigger_reset(void *data, u64 val)
   261	{
   262		struct mhi_controller *mhi_cntrl = data;
   263		struct mhi_device *mhi_dev = mhi_cntrl->mhi_dev;
   264		struct device *dev = &mhi_dev->dev;
   265		enum mhi_pm_state cur_state;
   266		int ret = -EIO;
   267	
   268		if (!mhi_is_active(mhi_cntrl))
   269			return -ENODEV;
   270	
   271		if (!val)
   272			return -EINVAL;
   273	
   274		ret = mhi_device_get_sync(mhi_dev, MHI_VOTE_DEVICE);
   275		if (ret) {
   276			dev_err(dev, "Device did not enter M0 state, MHI:%s, PM:%s\n",
   277				TO_MHI_STATE_STR(mhi_cntrl->dev_state),
   278				to_mhi_pm_state_str(mhi_cntrl->pm_state));
   279			return ret;
   280		}
   281	
   282		if (mhi_cntrl->rddm_image) {
   283			ret = mhi_force_rddm_mode(mhi_cntrl);
   284			goto exit_mhi_trigger_reset;
   285		}
   286	
   287		write_lock_irq(&mhi_cntrl->pm_lock);
   288		cur_state = mhi_tryset_pm_state(mhi_cntrl, MHI_PM_SYS_ERR_DETECT);
   289		write_unlock_irq(&mhi_cntrl->pm_lock);
   290	
   291		if (cur_state != MHI_PM_SYS_ERR_DETECT)
   292			goto exit_mhi_trigger_reset;
   293	
 > 294		mhi_pm_sys_err_handler(mhi_cntrl);
   295		ret = 0;
   296	
   297	exit_mhi_trigger_reset:
   298		mhi_device_put(mhi_dev, MHI_VOTE_DEVICE);
   299	
   300		return ret;
   301	}
   302	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 22797 bytes --]