From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D084C2D0F9 for ; Wed, 13 May 2020 09:48:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D85BC23126 for ; Wed, 13 May 2020 09:48:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589363315; bh=exXkvc1Pk18jelMY6JM7GsbunGm4/kMfPFEySFm36xU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Wvt6f15EEnJk63pKe3S78piOQHAUGntcPWLrXsZemt/LBmYXE/sUR06E5KLJzvYBA /VicLU5PZyXXLBBoua/zuYAhQCls9wc0heKGNJ2vavaHyN4hB3DS6S08PpDV2Xs1mR Lu0fKdiPqeBjW1xhtTPwB7AzUesRMkZNPSTTV824= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733090AbgEMJsf (ORCPT ); Wed, 13 May 2020 05:48:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:46952 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733077AbgEMJsb (ORCPT ); Wed, 13 May 2020 05:48:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 20C6620753; Wed, 13 May 2020 09:48:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589363310; bh=exXkvc1Pk18jelMY6JM7GsbunGm4/kMfPFEySFm36xU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wJ+GR9KSroUxlDBZSEaSvWhta4hCoPIHZbjDHKPAzv83yaFqPOWPC4tY3Gz+qkqiT ildaNETV8C6o7XMTFDU2GJAPjhqAixC2Rx/bcY6qcfuFWSy06aAIu8XwLUXE83IA8j cWpDesj9JEXUOOjb3ocxHAmF7fEoJb2R3JlUjynU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Anthony Felice , Akshay Bhat , Heiner Kallweit , Andrew Lunn , "David S. Miller" Subject: [PATCH 5.4 22/90] net: tc35815: Fix phydev supported/advertising mask Date: Wed, 13 May 2020 11:44:18 +0200 Message-Id: <20200513094411.029573562@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200513094408.810028856@linuxfoundation.org> References: <20200513094408.810028856@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Anthony Felice [ Upstream commit 4b5b71f770e2edefbfe74203777264bfe6a9927c ] Commit 3c1bcc8614db ("net: ethernet: Convert phydev advertize and supported from u32 to link mode") updated ethernet drivers to use a linkmode bitmap. It mistakenly dropped a bitwise negation in the tc35815 ethernet driver on a bitmask to set the supported/advertising flags. Found by Anthony via code inspection, not tested as I do not have the required hardware. Fixes: 3c1bcc8614db ("net: ethernet: Convert phydev advertize and supported from u32 to link mode") Signed-off-by: Anthony Felice Reviewed-by: Akshay Bhat Reviewed-by: Heiner Kallweit Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/toshiba/tc35815.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/toshiba/tc35815.c +++ b/drivers/net/ethernet/toshiba/tc35815.c @@ -644,7 +644,7 @@ static int tc_mii_probe(struct net_devic linkmode_set_bit(ETHTOOL_LINK_MODE_10baseT_Half_BIT, mask); linkmode_set_bit(ETHTOOL_LINK_MODE_100baseT_Half_BIT, mask); } - linkmode_and(phydev->supported, phydev->supported, mask); + linkmode_andnot(phydev->supported, phydev->supported, mask); linkmode_copy(phydev->advertising, phydev->supported); lp->link = 0;