From: Sean Young <sean@mess.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 2/3] input: serio: allow more than one byte to be sent at once
Date: Wed, 13 May 2020 17:09:28 +0100 [thread overview]
Message-ID: <20200513160928.GB9559@gofer.mess.org> (raw)
In-Reply-To: <20200513081646.GA770255@kroah.com>
On Wed, May 13, 2020 at 10:16:46AM +0200, Greg KH wrote:
> On Tue, May 12, 2020 at 10:07:24AM +0100, Sean Young wrote:
> > So this device is the infrared kind which rc-core (in drivers/media/rc/)
> > supports, remotes and such things (not for serial IR). So by using a
> > rc-core driver, it can use kernel IR decoding, BPF decoding, lirc chardev
> > and rc keymaps, etc.
>
> So why do you want to user serio for this? serio should only be for
> input devices with a serial protocol.
Admittedly this is a bit tenuous.
What I'm trying to do is write a kernel driver which uses the usb serial
drivers, and not write a poor man's version of usb serial in the IR driver.
> I think a custom usb driver that exposes the interfaces as input devices
> is going to be the simplest thing for you to do here as you will have
> full control over the packet size and format much easier. Odds are it
> will be less work overall for this.
Admittedly I don't think it will be much code, so maybe it won't be so
ugly. It's just the code duplication I was trying to avoid.
So, I'll go ahead and as you suggest.
Thank you for your time and thoughts on this.
Sean
prev parent reply other threads:[~2020-05-13 16:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200507135337.2343-1-sean@mess.org>
[not found] ` <20200507135337.2343-2-sean@mess.org>
[not found] ` <20200507202546.GM89269@dtor-ws>
[not found] ` <20200507205918.GA13370@gofer.mess.org>
[not found] ` <20200511065118.GA1293993@kroah.com>
2020-05-12 9:07 ` [PATCH 2/3] input: serio: allow more than one byte to be sent at once Sean Young
2020-05-12 17:37 ` Dmitry Torokhov
2020-05-13 17:04 ` Sean Young
2020-05-13 8:16 ` Greg KH
2020-05-13 16:09 ` Sean Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513160928.GB9559@gofer.mess.org \
--to=sean@mess.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).