From: Vidya Sagar <vidyas@nvidia.com>
To: <jingoohan1@gmail.com>, <gustavo.pimentel@synopsys.com>,
<lorenzo.pieralisi@arm.com>, <andrew.murray@arm.com>,
<bhelgaas@google.com>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>
Cc: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kthota@nvidia.com>, <mmaddireddy@nvidia.com>,
<vidyas@nvidia.com>, <sagar.tv@gmail.com>
Subject: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB
Date: Thu, 14 May 2020 00:38:55 +0530 [thread overview]
Message-ID: <20200513190855.23318-1-vidyas@nvidia.com> (raw)
commit 9e73fa02aa009 ("PCI: dwc: Warn if MEM resource size exceeds max for
32-bits") enables warning for MEM resources of size >4GB but prefetchable
memory resources also come under this category where sizes can go beyond
4GB. Avoid logging a warning for prefetchable memory resources.
Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
---
drivers/pci/controller/dwc/pcie-designware-host.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
index 42fbfe2a1b8f..a29396529ea4 100644
--- a/drivers/pci/controller/dwc/pcie-designware-host.c
+++ b/drivers/pci/controller/dwc/pcie-designware-host.c
@@ -366,7 +366,8 @@ int dw_pcie_host_init(struct pcie_port *pp)
pp->mem = win->res;
pp->mem->name = "MEM";
mem_size = resource_size(pp->mem);
- if (upper_32_bits(mem_size))
+ if (upper_32_bits(mem_size) &&
+ !(win->res->flags & IORESOURCE_PREFETCH))
dev_warn(dev, "MEM resource size exceeds max for 32 bits\n");
pp->mem_size = mem_size;
pp->mem_bus_addr = pp->mem->start - win->offset;
--
2.17.1
next reply other threads:[~2020-05-13 19:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 19:08 Vidya Sagar [this message]
2020-05-13 22:35 ` [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB Bjorn Helgaas
2020-05-18 15:54 ` Lorenzo Pieralisi
2020-05-19 13:55 ` Vidya Sagar
2020-05-19 14:58 ` Lorenzo Pieralisi
2020-05-19 17:08 ` Vidya Sagar
2020-05-19 18:20 ` Lorenzo Pieralisi
2020-05-19 22:08 ` Gustavo Pimentel
2020-05-20 2:33 ` Alan Mikhak
2020-05-22 14:04 ` Lorenzo Pieralisi
2020-05-20 11:06 ` [PATCH] " Lorenzo Pieralisi
2020-05-20 13:16 ` Thierry Reding
2020-05-20 17:51 ` Vidya Sagar
2020-05-20 11:17 ` Thierry Reding
2020-05-20 17:46 ` Vidya Sagar
2020-05-20 22:48 ` Rob Herring
2020-05-22 12:06 ` Thierry Reding
2020-05-22 13:32 ` Lorenzo Pieralisi
2020-05-22 14:06 ` Thierry Reding
2020-05-23 17:30 ` Vidya Sagar
2020-06-02 10:13 ` Vidya Sagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513190855.23318-1-vidyas@nvidia.com \
--to=vidyas@nvidia.com \
--cc=andrew.murray@arm.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mmaddireddy@nvidia.com \
--cc=sagar.tv@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).