From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D58DC433E1 for ; Thu, 14 May 2020 07:57:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BF7720575 for ; Thu, 14 May 2020 07:57:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725977AbgENH5g (ORCPT ); Thu, 14 May 2020 03:57:36 -0400 Received: from elvis.franken.de ([193.175.24.41]:53047 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725952AbgENH5K (ORCPT ); Thu, 14 May 2020 03:57:10 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jZ8js-0005U5-05; Thu, 14 May 2020 09:57:08 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id C4A2BC0493; Thu, 14 May 2020 09:49:16 +0200 (CEST) Date: Thu, 14 May 2020 09:49:16 +0200 From: Thomas Bogendoerfer To: Emil Velikov Cc: dri-devel@lists.freedesktop.org, Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH 05/11] MIPS: constify sysrq_key_op Message-ID: <20200514074916.GF5880@alpha.franken.de> References: <20200513214351.2138580-1-emil.l.velikov@gmail.com> <20200513214351.2138580-5-emil.l.velikov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513214351.2138580-5-emil.l.velikov@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 13, 2020 at 10:43:45PM +0100, Emil Velikov wrote: > With earlier commits, the API no longer discards the const-ness of the > sysrq_key_op. As such we can add the notation. > > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: linux-kernel@vger.kernel.org > Cc: Thomas Bogendoerfer > Cc: linux-mips@vger.kernel.org > Signed-off-by: Emil Velikov > --- > Please keep me in the CC list, as I'm not subscribed to the list. > > IMHO it would be better it this gets merged this via the tty tree. > --- > arch/mips/kernel/sysrq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Thomas Bogendoerfer Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]