From: Steven Rostedt <rostedt@goodmis.org>
To: Cheng Jian <cj.chengjian@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, <xiexiuqi@huawei.com>,
<bobo.shaobowang@huawei.com>, <huawei.libin@huawei.com>,
<chenwandun@huawei.com>, <mingo@redhat.com>
Subject: Re: [PATCH] ftrace: show debugging information when panic_on_warn set
Date: Fri, 15 May 2020 09:15:13 -0400 [thread overview]
Message-ID: <20200515091513.4947ff02@gandalf.local.home> (raw)
In-Reply-To: <20200515100828.7091-1-cj.chengjian@huawei.com>
On Fri, 15 May 2020 10:08:28 +0000
Cheng Jian <cj.chengjian@huawei.com> wrote:
> When an anomaly is detected in the function call modification
> code, ftrace_bug() is called to disable function tracing as well
> as give some warn and information that may help debug the problem.
>
> But currently, we call FTRACE_WARN_ON_ONCE() first in ftrace_bug(),
> so when panic_on_warn is set, we can't see the debugging information
> here. Call FTRACE_WARN_ON_ONCE() at the end of ftrace_bug() to ensure
> that the debugging information is displayed first.
>
> after this patch, the dmesg looks like:
>
Thanks, I'll add this to my queue.
-- Steve
prev parent reply other threads:[~2020-05-15 13:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 10:08 [PATCH] ftrace: show debugging information when panic_on_warn set Cheng Jian
2020-05-15 13:15 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515091513.4947ff02@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bobo.shaobowang@huawei.com \
--cc=chenwandun@huawei.com \
--cc=cj.chengjian@huawei.com \
--cc=huawei.libin@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).