From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3985C433E0 for ; Fri, 15 May 2020 12:53:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3CD820758 for ; Fri, 15 May 2020 12:53:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726223AbgEOMxt (ORCPT ); Fri, 15 May 2020 08:53:49 -0400 Received: from foss.arm.com ([217.140.110.172]:55580 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726141AbgEOMxs (ORCPT ); Fri, 15 May 2020 08:53:48 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B96E81042; Fri, 15 May 2020 05:53:47 -0700 (PDT) Received: from bogus (unknown [10.37.12.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C4DAD3F305; Fri, 15 May 2020 05:53:45 -0700 (PDT) Date: Fri, 15 May 2020 13:53:42 +0100 From: Sudeep Holla To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Steven Price , linux-kernel@vger.kernel.org, Arnd Bergmann , harb@amperecomputing.com Subject: Re: [PATCH v3 5/7] firmware: smccc: Refactor SMCCC specific bits into separate file Message-ID: <20200515125342.GB1591@bogus> References: <20200506164411.3284-1-sudeep.holla@arm.com> <20200506164411.3284-6-sudeep.holla@arm.com> <20200515114953.GE67718@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200515114953.GE67718@C02TD0UTHF1T.local> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 15, 2020 at 12:49:53PM +0100, Mark Rutland wrote: > On Wed, May 06, 2020 at 05:44:09PM +0100, Sudeep Holla wrote: > > In order to add newer SMCCC v1.1+ functionality and to avoid cluttering > > PSCI firmware driver with SMCCC bits, let us move the SMCCC specific > > details under drivers/firmware/smccc/smccc.c > > > > We can also drop conduit and smccc_version from psci_operations structure > > as SMCCC was the sole user and now it maintains those. > > > > No functionality change in this patch though. > > > > Signed-off-by: Sudeep Holla > > --- > > MAINTAINERS | 9 +++++++++ > > drivers/firmware/Makefile | 3 ++- > > drivers/firmware/psci/psci.c | 19 ++++--------------- > > drivers/firmware/smccc/Makefile | 3 +++ > > drivers/firmware/smccc/smccc.c | 26 ++++++++++++++++++++++++++ > > include/linux/arm-smccc.h | 11 +++++++++++ > > include/linux/psci.h | 2 -- > > 7 files changed, 55 insertions(+), 18 deletions(-) > > create mode 100644 drivers/firmware/smccc/Makefile > > create mode 100644 drivers/firmware/smccc/smccc.c > > > > Hi Mark, Lorenzo, > > > > I have replicated PSCI entry in MAINTAINERS file and added myself to > > for SMCCC entry. If you prefer I can merge it under PSCI. Let me know > > your preference along with other review comments. > > > +SECURE MONITOR CALL(SMC) CALLING CONVENTION (SMCCC) > > +M: Mark Rutland > > +M: Lorenzo Pieralisi > > +M: Sudeep Holla > > +L: linux-arm-kernel@lists.infradead.org > > +S: Maintained > > +F: drivers/firmware/smccc/ > > +F: include/linux/arm-smccc.h > > As per the above, I'm fine with having this separate from the PSCI > entry, and I'm fine with sharing this maintainership. > Thanks. > > diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h > > > +/** > > + * arm_smccc_version_init() - Sets SMCCC version and conduit > > + * @version: SMCCC version v1.1 or above > > + * @conduit: SMCCC_CONDUIT_SMC or SMCCC_CONDUIT_HVC > > + * > > + * When SMCCCv1.1 or above is not present, defaults to ARM_SMCCC_VERSION_1_0 > > + * and SMCCC_CONDUIT_NONE respectively. > > + */ > > +void __init arm_smccc_version_init(u32 version, enum arm_smccc_conduit conduit); > > Given we only expect the PSCI code to call this, could we avoid putting > this in a header and just define it within psci.c? > Sure I will do that, I was playing on safer side to avoid any tools picking on such trivial things 😄 > Either way: > > Acked-by: Mark Rutland > Thanks again. -- Regards, Sudeep