linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Vaibhav Agarwal <vaibhav.sr@gmail.com>
Cc: Mark Greer <mgreer@animalcreek.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
	linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org,
	devel@driverdev.osuosl.org
Subject: Re: [PATCH] greybus: audio: remove unused code
Date: Fri, 15 May 2020 15:44:12 +0200	[thread overview]
Message-ID: <20200515134412.GA2083757@kroah.com> (raw)
In-Reply-To: <CAAs3649-3dAmUqjLiEP8Ar3dKamp7ek1o0R5WN3g8kxTgz6fFg@mail.gmail.com>

On Thu, May 14, 2020 at 01:07:36AM +0530, Vaibhav Agarwal wrote:
> On Wed, May 13, 2020 at 11:15 PM Mark Greer <mgreer@animalcreek.com> wrote:
> >
> > On Thu, May 07, 2020 at 11:29:11PM +0200, Alexandre Belloni wrote:
> > > GREYBUS_AUDIO_MSM8994 is not an existing configuration option and as
> > > reported in September 2016, it depends on an "out-of-tree qualcomm audio
> > > driver". This driver never made it upstream.
> > >
> > > https://lore.kernel.org/lkml/20160921073905.GA31263@kroah.com/
> > >
> > > Moreover, there doesn't seem to be any interest in actually fixing the
> > > driver as it uses ASoC APIs that have been removed from the kernel in 2018
> > > as shown by its use of snd_soc_register_codec and
> > > snd_soc_codec_get_drvdata, removed in commit 999f7f5af8eb ("ASoC: remove
> > > Codec related code").
> > >
> > > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > > ---
> Hi Alexandre,
> 
> As mentioned in the mail archive referred, the GB Codec driver that is
> currently available in kernel tree is dependent on qualcomm audio
> driver. And some time later I made some minor modifications to remove
> the unnecessary dependencies. However, I missed to share the same with
> the community :(
> 
> Thanks to you for triggering the thread. Now, I could retrieve my local
> changes and I have been in the process of updating it again to make it
> compatible with latest kernel.
> 
> I'm planning to share the same here in the next few days.  I'll mark you
> in CC to seek your review comments as well.

I'll give you a few more days for that patch to be sent before I apply
this one...

thanks,

greg k-h

      reply	other threads:[~2020-05-15 13:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07 21:29 [PATCH] greybus: audio: remove unused code Alexandre Belloni
2020-05-13 17:45 ` Mark Greer
2020-05-13 19:37   ` Vaibhav Agarwal
2020-05-15 13:44     ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200515134412.GA2083757@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=elder@kernel.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgreer@animalcreek.com \
    --cc=vaibhav.sr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).