From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22823C433E1 for ; Fri, 15 May 2020 14:47:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 033F2207BB for ; Fri, 15 May 2020 14:47:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726257AbgEOOrw (ORCPT ); Fri, 15 May 2020 10:47:52 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:44728 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726163AbgEOOrw (ORCPT ); Fri, 15 May 2020 10:47:52 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: evelikov) with ESMTPSA id 329E22A238D Date: Fri, 15 May 2020 15:45:12 +0100 From: Emil Velikov To: Sebastian Reichel Cc: Sebastian Reichel , Rob Herring , Greg Kroah-Hartman , "Rafael J . Wysocki" , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCHv1 01/19] kobject: increase allowed number of uevent variables Message-ID: <20200515144512.GB2836808@arch-x1c3> References: <20200513185615.508236-1-sebastian.reichel@collabora.com> <20200513185615.508236-2-sebastian.reichel@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513185615.508236-2-sebastian.reichel@collabora.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/05/13, Sebastian Reichel wrote: > SBS battery driver exposes 32 power supply properties now, > which will result in uevent failure on (un)plugging the > battery. Other drivers (e.g. bq27xxx) are also coming close > to this limit, so increase it. > > Signed-off-by: Sebastian Reichel > --- > include/linux/kobject.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/kobject.h b/include/linux/kobject.h > index e2ca0a292e21..75e822569e39 100644 > --- a/include/linux/kobject.h > +++ b/include/linux/kobject.h > @@ -29,7 +29,7 @@ > #include > > #define UEVENT_HELPER_PATH_LEN 256 > -#define UEVENT_NUM_ENVP 32 /* number of env pointers */ > +#define UEVENT_NUM_ENVP 64 /* number of env pointers */ To be on the safe side I've checked systemd/udev. It's using ordered hashmap, so it's perfectly capable of handling the extra entries. Reviewed-by: Emil Velikov -Emil